[ 
https://issues.apache.org/jira/browse/NUTCH-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343534#comment-16343534
 ] 

ASF GitHub Bot commented on NUTCH-2505:
---------------------------------------

lianyuzhe commented on a change in pull request #282: fix for NUTCH-2505 
contributed by lianyuzhe
URL: https://github.com/apache/nutch/pull/282#discussion_r164474627
 
 

 ##########
 File path: src/java/org/apache/nutch/crawl/Generator.java
 ##########
 @@ -752,6 +752,7 @@ public Generator(Configuration conf) {
       }
     } catch (Exception e) {
       LOG.warn("Generator: exception while partitioning segments, exiting 
...");
+      LockUtil.removeLockFile(getConf(),lock);
 
 Review comment:
   do you think it is a good way to handle the Exception in the 
partitionSegment function? We can delete the segments is there is an Exception, 
and let the partition jobs continue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> nutch does not delete the .locked file, when the generator partition got an 
> exception
> -------------------------------------------------------------------------------------
>
>                 Key: NUTCH-2505
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2505
>             Project: Nutch
>          Issue Type: Bug
>          Components: generator
>            Reporter: Ajoy Lian
>            Priority: Major
>
> nutch does not delete the .locked file when the generator partition got an 
> exception. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to