[
https://issues.apache.org/jira/browse/NUTCH-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17391610#comment-17391610
]
ASF GitHub Bot commented on NUTCH-2885:
---------------------------------------
sebastian-nagel commented on a change in pull request #692:
URL: https://github.com/apache/nutch/pull/692#discussion_r680982506
##########
File path: conf/log4j2.xml
##########
@@ -0,0 +1,44 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!-- Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<Configuration status="info" name="Nutch" packages="">
+ <Properties>
+ <Property name="hadoop.log.dir">./logs</Property>
Review comment:
```suggestion
<!-- default values that can be overridden by system properties:
Note: the script bin/nutch sets these properties from the
environment variables
NUTCH_LOG_DIR and NUTCH_LOGFILE -->
<Property name="hadoop.log.dir">${sys:hadoop.log.dir:-./logs}</Property>
<Property
name="hadoop.log.file">${sys:hadoop.log.file:-hadoop.log}</Property>
```
In addition to staying backward-compatible: it's very handy to "redirect"
the `hadoop.log` files of different crawl projects (if it's not rename via
`hadoop.log.file`/NUTCH_LOGFILE) into a separate folder defined by
NUTCH_LOG_DIR similar to having separate configuration folders defined by
NUTCH_CONF_DIR. Note: this works only in local mode.
##########
File path: ivy/ivy.xml
##########
@@ -36,14 +36,10 @@
</publications>
<dependencies>
- <dependency org="org.slf4j" name="slf4j-api" rev="1.7.30"
conf="*->master" />
- <dependency org="org.slf4j" name="slf4j-log4j12" rev="1.7.30"
conf="*->master" />
-
- <!--dependency org="log4j" name="log4j" rev="1.2.15"
conf="*->default">
- <exclude org="javax.jms" name="jms" />
- <exclude org="com.sun.jdmk" name="jmxtools" />
- <exclude org="com.sun.jmx" name="jmxri" />
- </dependency-->
+ <dependency org="org.apache.logging.log4j" name="log4j-api"
rev="2.14.1" conf="*->master" />
+ <dependency org="org.apache.logging.log4j" name="log4j-core"
rev="2.14.1" conf="*->master" />
Review comment:
(indentation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@nutch.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Upgrade to Log4j2
> -----------------
>
> Key: NUTCH-2885
> URL: https://issues.apache.org/jira/browse/NUTCH-2885
> Project: Nutch
> Issue Type: Improvement
> Components: build, logging
> Reporter: Lewis John McGibbney
> Assignee: Lewis John McGibbney
> Priority: Major
> Fix For: 1.19
>
>
> log4j2 offers significant optimizations over log4j. I propose to upgrade.
> This will NOT drop the use of slf4j... just upgrade the underlying logging
> implementation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
