[
https://issues.apache.org/jira/browse/NUTCH-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392377#comment-17392377
]
ASF GitHub Bot commented on NUTCH-2885:
---------------------------------------
sebastian-nagel commented on a change in pull request #692:
URL: https://github.com/apache/nutch/pull/692#discussion_r681894793
##########
File path: conf/log4j2.xml
##########
@@ -0,0 +1,44 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!-- Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<Configuration status="info" name="Nutch" packages="">
+ <Properties>
+ <Property name="hadoop.log.dir">./logs</Property>
Review comment:
I've already tried the change using this "take system property
`hadoop.log.dir` if defined otherwise use `./logs` (cf. [Log4j2 - Property
Substitution](https://logging.apache.org/log4j/2.x/manual/configuration.html#PropertySubstitution)):
it allows to override the log file name and folder via the properties which
are also set by bin/nutch from the environment variables. Does the suggested
change look good to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@nutch.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Upgrade to Log4j2
> -----------------
>
> Key: NUTCH-2885
> URL: https://issues.apache.org/jira/browse/NUTCH-2885
> Project: Nutch
> Issue Type: Improvement
> Components: build, logging
> Reporter: Lewis John McGibbney
> Assignee: Lewis John McGibbney
> Priority: Major
> Fix For: 1.19
>
>
> log4j2 offers significant optimizations over log4j. I propose to upgrade.
> This will NOT drop the use of slf4j... just upgrade the underlying logging
> implementation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
