[
https://issues.apache.org/jira/browse/NUTCH-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392341#comment-17392341
]
ASF GitHub Bot commented on NUTCH-2885:
---------------------------------------
lewismc commented on a change in pull request #692:
URL: https://github.com/apache/nutch/pull/692#discussion_r681825788
##########
File path: ivy/ivy.xml
##########
@@ -36,14 +36,10 @@
</publications>
<dependencies>
- <dependency org="org.slf4j" name="slf4j-api" rev="1.7.30"
conf="*->master" />
- <dependency org="org.slf4j" name="slf4j-log4j12" rev="1.7.30"
conf="*->master" />
-
- <!--dependency org="log4j" name="log4j" rev="1.2.15"
conf="*->default">
- <exclude org="javax.jms" name="jms" />
- <exclude org="com.sun.jdmk" name="jmxtools" />
- <exclude org="com.sun.jmx" name="jmxri" />
- </dependency-->
+ <dependency org="org.apache.logging.log4j" name="log4j-api"
rev="2.14.1" conf="*->master" />
+ <dependency org="org.apache.logging.log4j" name="log4j-core"
rev="2.14.1" conf="*->master" />
Review comment:
Good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@nutch.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Upgrade to Log4j2
> -----------------
>
> Key: NUTCH-2885
> URL: https://issues.apache.org/jira/browse/NUTCH-2885
> Project: Nutch
> Issue Type: Improvement
> Components: build, logging
> Reporter: Lewis John McGibbney
> Assignee: Lewis John McGibbney
> Priority: Major
> Fix For: 1.19
>
>
> log4j2 offers significant optimizations over log4j. I propose to upgrade.
> This will NOT drop the use of slf4j... just upgrade the underlying logging
> implementation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
