[
https://issues.apache.org/jira/browse/NUTCH-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18116892#comment-18116892
]
ASF GitHub Bot commented on NUTCH-3197:
---------------------------------------
lewismc commented on code in PR #958:
URL: https://github.com/apache/nutch/pull/958#discussion_r4050836912
##########
src/bin/nutch:
##########
@@ -147,17 +147,18 @@ fi
local=true
-# NUTCH_JOB
-if [ -f "${NUTCH_HOME}"/*nutch*.job ]; then
- local=false
- for f in "$NUTCH_HOME"/*nutch*.job; do
+# NUTCH_JOB
+for f in "${NUTCH_HOME}"/*nutch*.job; do
Review Comment:
I agree. More than one *nutch*.job already means a messy NUTCH_HOME. This
change only makes the glob shellcheck-safe and takes the first match. Happy to
fail closed on multiples in a follow-up if you want that.
> Yetus: fix the real problems the precommit gate correctly reported
> ------------------------------------------------------------------
>
> Key: NUTCH-3197
> URL: https://issues.apache.org/jira/browse/NUTCH-3197
> Project: Nutch
> Issue Type: Sub-task
> Reporter: Lewis John McGibbney
> Priority: Major
>
> After baselines, the remaining interesting failures are things we would want
> fixed even without Yetus: misspellings in Java/docs that are not deliberate
> test inputs; eleven shellcheck *errors* in src/bin/crawl and src/bin/nutch
> (bad exit usage, glob/-f mistakes, string-vs-numeric compare, "$@"
> mishandling); Dockerfile structure issues; missing @audience/@stability
> shelldocs on crawl helpers; and a single jshint style nit in the parse-js
> sample.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
