[
https://issues.apache.org/jira/browse/NUTCH-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18116894#comment-18116894
]
ASF GitHub Bot commented on NUTCH-3197:
---------------------------------------
lewismc commented on PR #958:
URL: https://github.com/apache/nutch/pull/958#issuecomment-5736471994
Hi @sebastian-nagel thanks for the review. In summary, this PR now keeps
generate’s `1`. Env/Hadoop-not-found is `127`.
A dedicated empty-generate code can be its own JIRA if we want to break that
contract... I didn't bother here.
> Yetus: fix the real problems the precommit gate correctly reported
> ------------------------------------------------------------------
>
> Key: NUTCH-3197
> URL: https://issues.apache.org/jira/browse/NUTCH-3197
> Project: Nutch
> Issue Type: Sub-task
> Reporter: Lewis John McGibbney
> Priority: Major
>
> After baselines, the remaining interesting failures are things we would want
> fixed even without Yetus: misspellings in Java/docs that are not deliberate
> test inputs; eleven shellcheck *errors* in src/bin/crawl and src/bin/nutch
> (bad exit usage, glob/-f mistakes, string-vs-numeric compare, "$@"
> mishandling); Dockerfile structure issues; missing @audience/@stability
> shelldocs on crawl helpers; and a single jshint style nit in the parse-js
> sample.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
