[
https://issues.apache.org/jira/browse/NUTCH-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18116893#comment-18116893
]
ASF GitHub Bot commented on NUTCH-3197:
---------------------------------------
lewismc commented on code in PR #958:
URL: https://github.com/apache/nutch/pull/958#discussion_r4050847537
##########
src/bin/nutch:
##########
@@ -336,7 +337,7 @@ else
# check that hadoop can be found on the path
if [ $(which hadoop | wc -l ) -eq 0 ]; then
echo "Can't find Hadoop executable. Add HADOOP_COMMON_HOME/bin to the path
or run in local mode."
- exit -1;
Review Comment:
Yes this was some education for me. `1` would mean “no segment” for
bin/crawl + Generator... which is misleading/incorrect.
A missing Hadoop is now exit `127` (POSIX utility-not-found) in `bin/nutch`
and `bin/crawl`, so that path is no longer confused with an empty generate.
`ToolRunner` still mapping some exceptions to `1` is unchanged.
> Yetus: fix the real problems the precommit gate correctly reported
> ------------------------------------------------------------------
>
> Key: NUTCH-3197
> URL: https://issues.apache.org/jira/browse/NUTCH-3197
> Project: Nutch
> Issue Type: Sub-task
> Reporter: Lewis John McGibbney
> Priority: Major
>
> After baselines, the remaining interesting failures are things we would want
> fixed even without Yetus: misspellings in Java/docs that are not deliberate
> test inputs; eleven shellcheck *errors* in src/bin/crawl and src/bin/nutch
> (bad exit usage, glob/-f mistakes, string-vs-numeric compare, "$@"
> mishandling); Dockerfile structure issues; missing @audience/@stability
> shelldocs on crawl helpers; and a single jshint style nit in the parse-js
> sample.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
