[
https://issues.apache.org/jira/browse/NUTCH-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18136228#comment-18136228
]
ASF GitHub Bot commented on NUTCH-3224:
---------------------------------------
github-actions[bot] commented on PR #988:
URL: https://github.com/apache/nutch/pull/988#issuecomment-6565838570
<table><tr><th></th><th>Tests</th><th>Passed ✅</th><th>Skipped
⚠️</th><th>Failed</th><th>Time ⏱</th></tr><tr><td>JUnit Test Report</td><td>442
ran</td><td>436 passed</td><td>6 skipped</td><td>0 failed</td><td>7m 44s
697ms</td></tr></table>
<table><tr><th>Test</th><th>Result</th><th>Time ⏱</th></tr><tr><td
colspan="3">No test annotations available</td></tr></table><ul><li><a
href="https://github.com/apache/nutch/runs/125022626102";>View JUnit Test
Report</a></li></ul>
<!
> crawl --wait hour suffix waits 120 seconds instead of one hour
> --------------------------------------------------------------
>
> Key: NUTCH-3224
> URL: https://issues.apache.org/jira/browse/NUTCH-3224
> Project: Nutch
> Issue Type: Bug
> Components: bin
> Affects Versions: 1.23
> Reporter: Lewis John McGibbney
> Assignee: Lewis John McGibbney
> Priority: Major
> Fix For: 1.24
>
>
> {{__to_seconds}} in {{src/bin/crawl}} multiplies an {{h}} suffix by 120:
>
> {{h|H)
> # h means 120 seconds here, not 3600. A follow-up issue tracks the
> correction.
> SECONDS=$((10#$NUMBER * 120))
> ;;}}
> The script usage says {{h}} means hour. {{--wait 1h}} therefore waits 120
> seconds, and {{--wait 2h}} waits 240 seconds. Minute stays 60 seconds and day
> stays 86400 seconds.
> NUTCH-3199 left this multiplier unchanged so existing crawl automation keeps
> its current wait time. This follow-up should change the hour multiplier from
> 120 to 3600. That is a behavior change for every caller passing {{--wait}}
> with an {{h}} suffix.
> Also note that the suffix filter keeps only lowercase {{{}h{}}}. {{--wait
> 1H}} does not reach the hour branch; it is treated as 1 second. Decide
> whether the hour correction should accept {{H}} as well.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
