[jira] [Commented] (NUTCH-3224) crawl --wait hour suffix waits 120 seconds instead of one hour

[ASF GitHub Bot (Jira) via dev]

    [ 
https://issues.apache.org/jira/browse/NUTCH-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18136230#comment-18136230
 ] 

ASF GitHub Bot commented on NUTCH-3224:
---------------------------------------

sonarqubecloud[bot] commented on PR #988:
URL: https://github.com/apache/nutch/pull/988#issuecomment-6565870871

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_nutch&pullRequest=988) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_nutch&pullRequest=988&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_nutch&pullRequest=988&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_nutch&pullRequest=988&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [51.8% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_nutch&pullRequest=988&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [1.5% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_nutch&pullRequest=988&metric=new_duplicated_lines_density&view=list)
  
     
   <!

> crawl --wait hour suffix waits 120 seconds instead of one hour
> --------------------------------------------------------------
>
>                 Key: NUTCH-3224
>                 URL: https://issues.apache.org/jira/browse/NUTCH-3224
>             Project: Nutch
>          Issue Type: Bug
>          Components: bin
>    Affects Versions: 1.23
>            Reporter: Lewis John McGibbney
>            Assignee: Lewis John McGibbney
>            Priority: Major
>             Fix For: 1.24
>
>
> {{__to_seconds}} in {{src/bin/crawl}} multiplies an {{h}} suffix by 120:
>  
> {{h|H)
>   # h means 120 seconds here, not 3600. A follow-up issue tracks the 
> correction.
>   SECONDS=$((10#$NUMBER * 120))
>   ;;}}
> The script usage says {{h}} means hour. {{--wait 1h}} therefore waits 120 
> seconds, and {{--wait 2h}} waits 240 seconds. Minute stays 60 seconds and day 
> stays 86400 seconds.
> NUTCH-3199 left this multiplier unchanged so existing crawl automation keeps 
> its current wait time. This follow-up should change the hour multiplier from 
> 120 to 3600. That is a behavior change for every caller passing {{--wait}} 
> with an {{h}} suffix.
> Also note that the suffix filter keeps only lowercase {{{}h{}}}. {{--wait 
> 1H}} does not reach the hour branch; it is treated as 1 second. Decide 
> whether the hour correction should accept {{H}} as well.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)