[
https://issues.apache.org/jira/browse/NUTCH-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18136226#comment-18136226
]
ASF GitHub Bot commented on NUTCH-3224:
---------------------------------------
github-actions[bot] commented on PR #988:
URL: https://github.com/apache/nutch/pull/988#issuecomment-6565741220
## Apache Yetus test-patch report
| |
|------------|
| -1 overall |
| | | |
| |
|------|------------|---------|-------------------------------------------------------|---------------------------------------------------------------------|
| Vote | Subsystem | Runtime | Log
| Comment |
| | | |
| Prechecks |
| +1 | dupname | 0m 0s |
| No case conflicting files found. |
| +1 | @author | 0m 0s |
| The patch does not contain any @author tags. |
| | | |
| master Compile Tests |
| | | |
| Patch Compile Tests |
| +1 | codespell | 0m 1s |
| No new issues. |
| +1 | detsecrets | 0m 31s |
| No new issues. |
| +1 | blanks | 0m 0s |
| The patch has no blanks issues. |
| +1 | shellcheck | 0m 0s |
| No new issues. |
| -1 | shelldocs | 0m 1s |
[/results-shelldocs.txt](/results-shelldocs.txt)\</\> | The patch generated 6
new + 0 unchanged - 0 fixed = 6 total (was 0) |
| +1 | xmllint | 0m 0s |
| No new issues. |
| +1 | yamllint | 0m 0s |
| No new issues. |
| | | |
| Other Tests |
| +1 | asflicense | 0m 1s |
| The patch does not generate ASF License warnings. |
| | | 0m 39s |
| |
| |
|
|----------------|---------------------------------------------------------------------------------------------------------------------------------|
| Subsystem | Report/Notes
|
| GITHUB PR | https://github.com/apache/nutch/pull/988
|
| Optional Tests | dupname asflicense codespell detsecrets xmllint yamllint
shellcheck shelldocs |
| uname | Linux 2dcdb93d8aa6 7.0.0-1017-azure \#17~24.04.1-Ubuntu
SMP PREEMPT Thu Sep 24 18:46:57 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild
|
| Personality | /github/workspace/.yetus/personality.sh
|
| git revision | master / 29c8f7d8f12a6aead580e184149a76ad04da7beb
|
| modules | C: . U: .
|
| versions | git=2.34.1 codespell=2.4.1 detsecrets=1.5.0
shellcheck=0.10.0 xmllint=20913 yamllint=1.35.1
|
| Powered by | Apache Yetus 0.15.1 https://yetus.apache.org
|
This message was automatically generated.
<!
> crawl --wait hour suffix waits 120 seconds instead of one hour
> --------------------------------------------------------------
>
> Key: NUTCH-3224
> URL: https://issues.apache.org/jira/browse/NUTCH-3224
> Project: Nutch
> Issue Type: Bug
> Components: bin
> Affects Versions: 1.23
> Reporter: Lewis John McGibbney
> Assignee: Lewis John McGibbney
> Priority: Major
> Fix For: 1.24
>
>
> {{__to_seconds}} in {{src/bin/crawl}} multiplies an {{h}} suffix by 120:
>
> {{h|H)
> # h means 120 seconds here, not 3600. A follow-up issue tracks the
> correction.
> SECONDS=$((10#$NUMBER * 120))
> ;;}}
> The script usage says {{h}} means hour. {{--wait 1h}} therefore waits 120
> seconds, and {{--wait 2h}} waits 240 seconds. Minute stays 60 seconds and day
> stays 86400 seconds.
> NUTCH-3199 left this multiplier unchanged so existing crawl automation keeps
> its current wait time. This follow-up should change the hour multiplier from
> 120 to 3600. That is a behavior change for every caller passing {{--wait}}
> with an {{h}} suffix.
> Also note that the suffix filter keeps only lowercase {{{}h{}}}. {{--wait
> 1H}} does not reach the hour branch; it is treated as 1 second. Decide
> whether the hour correction should accept {{H}} as well.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
