davids5 commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725892
########## File path: tools/nxstyle.c ########## @@ -50,6 +50,45 @@ #define LINE_SIZE 512 +#define FATAL(m) message(FATAL, (m), 0, 0) +#define FATALFL(m,s) message(FATAL, (m), -1, -1) +#define WARN(m, l, o) message(WARN, (m), (l), (0)) +#define ERROR(m, l, o) message(ERROR, (m), (l), (0)) +#define INFO(m, l, o) message(INFO, (m), (l), (0)) + +/**************************************************************************** + * Private types + ****************************************************************************/ + +enum class_e { + INFO, + WARN, + ERROR, + FATAL +}; + +const char *class_text[] = +{ + "info", + "warning", + "error", + "fatal" +}; + +enum file_e { + unknown, + c_header, + c_source, +}; + +/**************************************************************************** + * Private data + ****************************************************************************/ + +int g_status = 0; +char *g_file_name = ""; +enum file_e g_file_type = unknown; Review comment: ```suggestion static enum file_e g_file_type = unknown; ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services