patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360726623
##########
File path: tools/Makefile.unix
##########
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -C "$(TOPDIR)/$(APPDIR)" TOPDIR="$(TOPDIR)" distclean
endif
+
+check_format:
+ $(call colorecho,'Checking NuttX formatting with nxstyle')
Review comment:
There is a missing dependency here. tools/nxstyle[.exe] is not build by
default but must be explictly built. Can you add
`nxstyle$(EXEEXT):
$(MAKE) -C tools -f Makfile.host nxstyle$(EXEEXT)
check_format: nxstyle$(EXEEXT)
...`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
