davids5 commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360727667
########## File path: tools/Makefile.unix ########## @@ -192,11 +192,18 @@ NUTTXNAME = nuttx BIN = $(NUTTXNAME)$(EXEEXT) all: $(BIN) -.PHONY: dirlinks context clean_context check_context config oldconfig menuconfig nconfig qconfig gconfig export subdir_clean clean subdir_distclean distclean apps_clean apps_distclean +.PHONY: dirlinks context clean_context check_context config oldconfig menuconfig nconfig qconfig gconfig export subdir_clean clean subdir_distclean distclean apps_clean apps_distclean check_format ifeq ($(GIT_DIR),y) Review comment: @patacongo - All the code review feeback is in. I am done for the day. Please send PR to this branch if you can help fix the Makefiles stuff. and script. After all I did fix all you CS violations that are on master! We are big on QPQ here!!! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
