patacongo commented on a change in pull request #2: Master pr nxstyle 
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360732967
 
 

 ##########
 File path: tools/check_code_style.sh
 ##########
 @@ -0,0 +1,33 @@
+#!/usr/bin/env bash
+
 
 Review comment:
   Missing license header.  Must be included on all scripts.  Should this be 
apache or BSD.  BSD is safe for now because all of the other files have BSD 
headers and this will be properly updated to the apache license when that 
effort begins.  It cannot come into the repository with no license.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to