patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360728732
##########
File path: tools/Makefile.unix
##########
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -C "$(TOPDIR)/$(APPDIR)" TOPDIR="$(TOPDIR)" distclean
endif
+
+check_format:
+ $(call colorecho,'Checking NuttX formatting with nxstyle')
+ @$(TOPDIR)/tools/check_code_style.sh
+ @cd "$(SRC_DIR)" && git diff --check
Review comment:
The simplest solution would be to make the whole check_format target
available only ifeq ($(GIT_DIR),y). that would only be conditional logic at
708 and 195. Pretty easy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
