patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360728886
########## File path: tools/nxstyle.c ########## @@ -171,20 +238,21 @@ int main(int argc, char **argv, char **envp) } else { - fprintf(stderr, "Invalid number of arguments\n"); + FATAL("Invalid number of arguments\n"); show_usage(argv[0], 1); } instream = fopen(filename, "r"); if (!instream) { - fprintf(stderr, "Failed to open %s\n", argv[1]); + FATALFL("Failed to open", argv[1]); return 1; } /* Are we parsing a header file? */ hdrfile = false; + g_file_type = unknown; ext = strrchr(filename, '.'); Review comment: Unresolved. Please make alignment style consistent. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services