Hi Thomas, On 9/22/20, Thomas Axelsson <thomas.axels...@actia.se> wrote: > Hi, > > I have now created a PR for a simple IMXRT ADC driver. ( > https://github.com/apache/incubator-nuttx/pull/1868 ) >
Nice work, thank you! > The names of register bit values for ADC_CFG:ADSTS do not match between > IMXRT 1020 and 1050/1060. > This PR changes them to match for 1050/1060, but I guess it should be split > into two files - or possibly have an ifdef for the chip? Please provide > advise on this issue. > https://github.com/apache/incubator-nuttx/pull/1868/files#diff-d732b4fa83e7f3fbf6ac34c1203cef60 > I think since iMXRT1050/60 are similar, you could add it to imxrt105x_pinmux.h as well, but for 1020 it is better to avoid reusing it. BR, Alan
