This change has no functional impact, so it does not meet the "absolutely necessary and unavoidable" constraint. But this commit will affect everyone's understanding of the kernel's key features, which is a good thing in further. I think it meets the "necessary and unavoidable" constraint. In addition, I don't think PMC has any privileges. Anyone can vote on the mailing list, and we also need the opinions of experts like you.
BRs, Takashi Yamamoto <yamam...@midokura.com.invalid> 于2025年4月10日周四 10:37写道： > > > On Thu, Apr 10, 2025 at 10:44 AM chao an <magicd...@gmail.com> wrote: > >> Yamamoto san, there may be some objective factors here, but we may >> already be on the way to voting. could you please vote again based on the >> changes from the "code" perspective? >> > > i've read CONTRIBUTING.md 1.12 and 1.13 a few times. > but i don't see what's i'm missing. > do people here think this change is "absolutely necessary and unavoidable"? > > >> >> BRs, >> >> Takashi Yamamoto <yamam...@midokura.com.invalid> 于2025年4月9日周三 06:56写道： >> >>> -1 >>> >>> reading the recently added text in CONTRIBUTING.md, >>> this change doesn't seem even eligible for voting because >>> it is not "absolutely necessary and unavoidable". >>> >>> i personally like the change itself and prefer loosening the rules in >>> CONTRIBUTING.md though. >>> >>> >>> On Mon, Apr 7, 2025 at 6:13 PM chao an <magicd...@gmail.com> wrote: >>> >>>> Hi community, >>>> >>>> Some green hand and individual developer who are not familiar with >>>> nuttx may be confused by the naming of modlib, in currect implement, modlib >>>> as an elf loader and parser, does not provide any features other than elf. >>>> >>>> In this pull request, I plan to rename modlib to elf, and adjust it >>>> from the architecture level as follows: >>>> >>>> https://github.com/apache/nuttx/pull/15765 >>>> >>>> >>>> [image: image.png] >>>> >>>> In addition from other popular operating systems, different loadable >>>> types are all implemented in binfmt. Therefore, it is also impossible for >>>> modlib to support formats other than ELF in the future: >>>> >>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c >>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf_fdpic.c >>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_flat.c >>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_misc.c >>>> https://github.com/torvalds/linux/blob/master/fs/binfmt_script.c >>>> >>>> https://github.com/alexbousso/kernel_2.4.18-14/blob/master/fs/binfmt_coff.c >>>> >>>> This is where they belong: >>>> https://github.com/apache/nuttx/tree/master/binfmt >>>> >>>> >>>> So I need your vote here: >>>> If you prefer modlib, please reply with -1. >>>> If you recommend libelf, please reply with +1. >>>> >>>> BRs, >>>> >>>
