On Wed, Apr 9, 2025 at 9:22 AM Tomek CEDRO <to...@cedro.info> wrote: > > Hi Takashi :-) > > There were long discussions on the mailing list, then voting, then > discussion on the PR, and comes after lots of breaking changes being > too freely merged into the upstream, sometimes with laconic > description and sometimes without even testing. This is to focus more > on long term self-compatibility and maintenance and improve overall > pr/commit/code quality. As you can see we are testing "new process" of > breaking changes processing.. more attention is given to breaking > stuff.. pr/commits descriptions are better.. we have discussions on > the mailing list prior breaking change is merged, and it is still > possible to introduce breaking stuff, but more carefully. Please take > a look at mailing list archives. > > Rationale behind this change modlib -> libelf is to complete prior > changes chain, as explained by the author. > > If you like the change please vote +1 and it will pass. Your -1 blocks > the change.
i'm not a "NuttX PMC" member and thus my vote is not a "binding vote" and do not block the change, does it? > > Thanks :-) > Tomek > > > > > On Wed, Apr 9, 2025 at 12:56 AM Takashi Yamamoto > <yamam...@midokura.com.invalid> wrote: > > > > -1 > > > > reading the recently added text in CONTRIBUTING.md, > > this change doesn't seem even eligible for voting because > > it is not "absolutely necessary and unavoidable". > > > > i personally like the change itself and prefer loosening the rules in > > CONTRIBUTING.md though. > > > > > > On Mon, Apr 7, 2025 at 6:13 PM chao an <magicd...@gmail.com> wrote: > >> > >> Hi community, > >> > >> Some green hand and individual developer who are not familiar with nuttx > >> may be confused by the naming of modlib, in currect implement, modlib as > >> an elf loader and parser, does not provide any features other than elf. > >> > >> In this pull request, I plan to rename modlib to elf, and adjust it from > >> the architecture level as follows: > >> > >> https://github.com/apache/nuttx/pull/15765 > >> > >> > >> > >> > >> In addition from other popular operating systems, different loadable types > >> are all implemented in binfmt. Therefore, it is also impossible for modlib > >> to support formats other than ELF in the future: > >> > >> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c > >> https://github.com/torvalds/linux/blob/master/fs/binfmt_elf_fdpic.c > >> https://github.com/torvalds/linux/blob/master/fs/binfmt_flat.c > >> https://github.com/torvalds/linux/blob/master/fs/binfmt_misc.c > >> https://github.com/torvalds/linux/blob/master/fs/binfmt_script.c > >> https://github.com/alexbousso/kernel_2.4.18-14/blob/master/fs/binfmt_coff.c > >> > >> This is where they belong: > >> https://github.com/apache/nuttx/tree/master/binfmt > >> > >> > >> So I need your vote here: > >> If you prefer modlib, please reply with -1. > >> If you recommend libelf, please reply with +1. > >> > >> BRs, > > > > -- > CeDeROM, SQ7MHZ, http://www.tomek.cedro.info
