Hi Michal, On Sat, Aug 9, 2025 at 5:08 PM Michał Łyszczek <michal.lyszc...@bofc.pl> wrote:
> On 2025-08-09 16:47:01, Alan C. Assis wrote: > > * It passes a wrong message, as something very negative (not all > > breaking are bad, or shouldn't be) > > * Someone reading our git history could get a wrong impression of the > > project > > * It will cluttering the title, by convention the title should have only > 50 > > chars > > * It doesn't follow the conventional commits specification: > > https://www.conventionalcommits.org/en/v1.0.0/ > > > > So, please verify the suggested modification here: > > https://github.com/apache/nuttx/pull/16823 > > > > The suggestion as defined by conventional commits is to include the > > "BREAKING CHANGE: " in the commit log message (foot). > That exclamation mark is actually pretty sweet. Does not clutter, easy to > grep. > And details can be later described in footer in a single sentence like > "funcion > X has been renamed to Y". Just a note. Wouldn't standard footer be in form > Yes, the exclamation mark is a good alternative as well. It will add only 1 char in the title and will be very discrete. > "Breaking-change:"? There are already things like "Signed-off-by:". > Good question, no idea why they didn't define it as "Breaking-change:", maybe it could be suggested to be included in a new specification. BR, Alan
