Hi Michael, Thanks for your contribution. Your PR has been merged.
regards, sathwik On Mon, Jan 29, 2018 at 9:04 PM, Michael Hahn <mhahn....@gmail.com> wrote: > Hi Sathwik, > > sure! > > I merged your commits into my fork and replaced the tabs with spaces > (hopefully) in all affected source files. > The PR should reflect the updates now. > > By the way, is there any source code formatting guideline/template for ODE > to avoid conflicts in future? :-) > > Best regards, > Michael > > -----Ursprüngliche Nachricht----- > Von: Sathwik B P [mailto:sathwik...@gmail.com] > Gesendet: Montag, 29. Januar 2018 11:53 > An: dev@ode.apache.org > Betreff: Re: Extension activities > > Hi Michael, > > Sorry for the delay. > > I had a brief look and it seems good to me. > The PR has a lot of tabs in the source, would it be possible to remove > them and resubmit the PR? I also have updgraded trunk to JAVA 8, there are > couple of commit for it from the point when your repo forked, can you take > it up in your repo and the new PR should be a smooth checkin. > > Would that be possible? > > regards, > sathwik > > On Wed, Jan 17, 2018 at 3:16 PM, Michael Hahn <mhahn....@gmail.com> wrote: > > > Hi Sathwik, > > > > sure, the forked repo is available at: https://github.com/hahnml/ode > > > > Best regards, > > Michael > > > > -----Ursprüngliche Nachricht----- > > Von: Sathwik B P [mailto:sathwik...@gmail.com] > > Gesendet: Mittwoch, 17. Januar 2018 10:34 > > An: dev@ode.apache.org > > Betreff: Re: Extension activities > > > > Hi Micheal, > > > > Thanks for the contribution. > > > > Will have a look at it when I get sometime. Can you share your forked > > repo link? > > > > regards, > > sathwik > > > > On Mon, Jan 15, 2018 at 6:20 PM, Michael Hahn <mhahn....@gmail.com> > wrote: > > > > > Hi Sathwik, > > > > > > as discussed I created a corresponding PR for porting the extension > > > activity support (https://github.com/apache/ode/pull/4). > > > In addition, I added an initial BPEL REST extension activity bundle > > > as an example together with related test cases in 'bpel-test' project. > > > > > > Looking forward to your feedback, let me know if something is > > > missing or has to be adapted :-) > > > > > > Best regards, > > > Michael > > > > > > -----Ursprüngliche Nachricht----- > > > Von: Sathwik B P [mailto:sathwik...@gmail.com] > > > Gesendet: Mittwoch, 29. November 2017 06:11 > > > An: dev@ode.apache.org > > > Betreff: Re: Extension activities > > > > > > Micheal, > > > Am done with porting to trunk. You can start on your PR. > > > > > > On Nov 25, 2017 13:17, "Sathwik B P" <sathwik...@gmail.com> wrote: > > > > > > > MIchael, > > > > > > > > Just hold on to making changes for the trunk, am bringing the > > > > 1.3.8 commits from the release branch to the trunk. I should > > > > probably done in about 2-3 days. Major library upgrades are coming > in. > > > > > > > > Just to summarize the changes in the trunk JACOB has been moved > > > > into a different sub project > > > > [https://github.com/apache/ode-jacob], the new OModel is here > > > > https://github.com/apache/ode/tree/master/bpel-nobj > > . > > > > > > > > The compiler has undergone changes. I believe porting of extension > > > > activities onto this new model will not be straight forward as the > > > > extension feature was built on the older OModel. > > > > > > > > regards, > > > > sathwik > > > > > > > > On Fri, Nov 24, 2017 at 5:43 PM, Sathwik B P > > > > <sathwik...@gmail.com> > > > wrote: > > > > > > > >> Micheal, > > > >> > > > >> I am working towards 1.3.8 release. We cannot bring the extension > > > >> activity feature on 1.3.x branch > > > >> > > > >> On Nov 24, 2017 15:46, "Michael Hahn" <mhahn....@gmail.com> wrote: > > > >> > > > >>> Hi Sathwik, > > > >>> > > > >>> thanks for the pointers. > > > >>> > > > >>> I've seen on GitHub that you are currently working on the > "ode-1.3.x" > > > >>> branch. > > > >>> Should I also do the porting based on that branch or better on > > > >>> the master? > > > >>> > > > >>> Regards, > > > >>> Michael > > > >>> > > > >>> -----Ursprüngliche Nachricht----- > > > >>> Von: Sathwik B P [mailto:sathwik...@gmail.com] > > > >>> Gesendet: Donnerstag, 23. November 2017 14:52 > > > >>> An: dev@ode.apache.org > > > >>> Betreff: Re: Extension activities > > > >>> > > > >>> Hi Hahn, > > > >>> > > > >>> Good to hear about your interest on porting Extension activities > > > >>> onto the trunk. It only exists in APACHE_ODE_2.X-experimental" > > branch. > > > >>> > > > >>> I suppose these should be the initial commits from Tammo, > > > >>> [ODE-159, ODE-160] > > > >>> https://github.com/apache/ode/commit/5ef69232cc6f19cf2818dd1 > > > >>> b110416b959297126 > > > >>> https://github.com/apache/ode/commit/1d5fa185a77c944e8d4a708 > > > >>> b451611fa74d5c2dc > > > >>> > > > >>> You can just go up the commits if there are more. > > > >>> > > > >>> > > > >>> regards, > > > >>> sathwik > > > >>> > > > >>> On Thu, Nov 23, 2017 at 4:39 PM, Michael Hahn > > > >>> <mhahn....@gmail.com> > > > >>> wrote: > > > >>> > > > >>> > Hi, > > > >>> > > > > >>> > I'm actually very interested in the support of BPEL extension > > > >>> > activities in ODE and also willing to help to integrate/build > > > >>> > the feature :-) Some years ago I was able to successfully port > > > >>> > the extension activity support from the > > "APACHE_ODE_2.X-experimental" > > > >>> > branch into an ODE 1.3.4 release. > > > >>> > > > > >>> > So, if someone can give me a pointer where to find the most > > > >>> > recent version of the extension activity related classes, I > > > >>> > can integrate the feature into the current trunk and provide > > > >>> > the result as a pull request. Else I can also simply go with > > > >>> > the version in the "APACHE_ODE_2.X-experimental" branch as a > > > >>> > starting > > point. > > > >>> > > > > >>> > Regards, > > > >>> > Michael > > > >>> > > > > >>> > -----Ursprüngliche Nachricht----- > > > >>> > Von: Sathwik B P [mailto:sath...@apache.org] > > > >>> > Gesendet: Mittwoch, 18. Oktober 2017 15:53 > > > >>> > An: dev@ode.apache.org > > > >>> > Betreff: Re: Extension activities > > > >>> > > > > >>> > Hi Oliver, > > > >>> > > > > >>> > ODE 2.0 branch was an experimental branch and is not > > > >>> > maintained since a very long time. I will have to revisit it > > > >>> > myself, in case it involves changes to the ODE object model, > > > >>> > then we cannot bring it on any of 1.3.x releases because of > > > >>> > chances of breaking binary > > > >>> compatibilities. > > > >>> > > > > >>> > In order to make new features available, we moved towards JSON > > > >>> > based state serialization away from JAVA serialization in the > > > >>> > trunk which is in 1.4 release. > > > >>> > > > > >>> > Currently, we are seeking new committers, you might want to > > > >>> > discuss the feature that you are willing to contribute and > > > >>> > probably help us > > > >>> build it. > > > >>> > > > > >>> > regards, > > > >>> > sathwik > > > >>> > > > > >>> > > > > >>> > On Wed, Oct 18, 2017 at 4:22 PM, Oliver Kopp > > > >>> > <kopp....@gmail.com> > > > >>> wrote: > > > >>> > > > > >>> > > Hi, > > > >>> > > > > > >>> > > In the context of our usage, we rely on BPEL extension > > > >>> > > activity support within ODE for enabling the invocation of > > > >>> > > REST APIs through a corresponding extension bundle. We > > > >>> > > therefore ported the extension activity support from the > > > >>> > > 2.0-alpha branch (already some years ago and therefore not > > > >>> > > up to date with "latest" version on GitHub) into the current > > > >>> > > 1.3.7 release build which works. The problem is that by > > > >>> > > changing the source code of the official ODE 1.3.7 release, > > > >>> > > we have to ship our extended version of ODE and take over > > > >>> > > responsibilities regarding licenses, etc. Therefore, it > > > >>> > > would be really nice if there will be an ODE 1.3.x release > > > >>> > > with integrated extension activity support, so that we can > > > >>> > > use/refer to ODE as it is and as a result treat it as a > > > >>> > > ready to use open source middleware such as > > > Tomcat, we just use within our ecosystem. > > > >>> > > > > > >>> > > Do you see any chance to release a corresponding > > > >>> > > distribution that contains extension activity support in the > near future? > > > >>> > > > > > >>> > > In return we are really interested in open sourcing our > > > >>> > > BPEL4REST extension bundle so that it can be shipped as a > > > >>> > > feature > > > with ODE! > > > >>> > > 👨🔧 > > > >>> > > > > > >>> > > Cheers, > > > >>> > > > > > >>> > > Oliver > > > >>> > > > > > >>> > > > > >>> > > > > >>> > > > >>> > > > > > > > > > > > > > > > >
