Re: svn commit: r585267 - in /ofbiz/trunk/framework: base/build.xml build.xml

[David E Jones]

1. this is the problem and why
2. this is what we should do about it



-David


On Oct 17, 2007, at 11:07 AM, Adam Heath wrote:

Why are we even having this discussion? It seems like the original change was trying to fix stuff that isn't broken... and now we're going on and on about it, even though it wasn't broken in the first place. If anyone wants to discuss it further, I recommend writing things in the form of: Without a problem to attack it seems like we're just running in circles. That it's not fun, but some of us have other things we'd rather be doing. ;)

Adam Heath wrote:

David E Jones wrote:

Not sure if I like this... My preference would be that each build file only owns its directory and below. This change makes a lower level build

file manage something higher level.


flexibility?


be expected though...


future and just need to be changed back.

What if the framework or base directories move, or we want more build I can see how if you build just the base component or just the framework directory that the ofbiz.jar file won't get updated. In a way that would If anyone else has an opinion on this please chime in. It's not a big deal, but is one of those things that could make life difficult in the

only the top-level.

The reason why I did this, is quite often I'd cd into framework/base,
and just run ant there.  Then I'd wonder why my changes hadn't taken
place, because the ofbiz.jar at the top-level hadn't been updated.


the startup to pull from framework/base.

In that argument, framework/build.xml should not update it either, and Maybe a better change would to not copy the file at all, and just modify

I'm not wedded to this change, btw; if enough others don't think it's
wise, I'll undo it.

I looked into altering things to pull from framework/base, so that no
top-level ofbiz.jar would be nescessary.  While modifying the

is hard, so having it automatically updated is the correct approach.
Whether that's done in framework/base, or some place else, is what is
being discussed.

Another idea, that doesn't sit well with me.  Shouldn't
framework/base/src/start be split into it's own component?  Maybe
framework/start, or just move that code to the top-level.  After all,

the top-level, then this argument would become moot.

scripts/code is simple enough, there is plenty of documentation and best practices that point to the ofbiz.jar in the top-level. Changing humans it's just the start code that goes into ofbiz.jar. If it were moved to

smime.p7s
Description: S/MIME cryptographic signature