Hi Michael,
Le 17/08/2017 à 10:44, Michael Brohl a écrit :
Hi Nicolas,
thank you very much for your ongoing work on this topic, I greatly
appreciate it :-)
:) thanks, you escape me from the loneliness
I'm looking forward to have a deeper look into your solutions but have
to wait until my return on end of August. The concept, as I understand
it, provides an extendable mechanism to build themes on base of other
themes, which seems very flexible.
It's exactly the purpose with keep in mind to separate the model and
convention on framework and all surcharge for the rendering or structure
page in themes
I'm in favor to have you commit the changes to trunk as long as they
don't break existing functionality and themes. It would be much easier
to work together then.
Normally I haven't detected a major regression. Just detect a problem
when you have some sessions already enabled, when you change your theme,
it's updated only on the current session where you did it and the newer.
But the others enabled session keep the previous theme.
If some people are feedback on some regression, I'm really happy to
understand and resolve it but I'm fear that we need to wait the commit
in trunk.
Cheers
Nicolas
I'll have some detailed questions which I will put in another message
to prevent confusion.
Again, thank you very much for your efforts,
Best regards,
Michael
Am 16.08.17 um 13:49 schrieb Nicolas Malin:
Hello;
To continue the common-theme subject, I haven't see negative return
to the issue Create a common theme (OFBIZ-9138) [1] and on threads on
the same subject [2] and the additional theme xml definition [3], I
suggest to create a documentation on the wiki how work the "theme
engine" and commit the current git branch [4] [5] on trunk
After that, the engine will be present on the trunk and we continue
the work to :
* Clean the common-theme and create a real theme
* Migrate properly the current theme with the new structure
* Analyze more how organize the screen api
But don't panic, before that I'm listening to all suggest or remarks ;)
Nicolas
[1] https://issues.apache.org/jira/browse/OFBIZ-9138
[2]
https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E
[3]
https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E
[4] https://github.com/nmalin/ofbiz-framework/tree/common-theme
[5]
https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1
