Hi Jacques, inline...
Am 13.02.20 um 11:43 schrieb Jacques Le Roux:
Yes, I confused the date (Jan vs. Feb, time goes by too quick).I speak of the commits towards https://issues.apache.org/jira/browse/OFBIZ-11317. The issue was created and on the same day it was committed. It was not yesterday but the timeline between submit and commit is the same.I don't want to argue too much about that, so I hope it will be the end of this exchange. You are right about the Jira and commit moment, they are same.But I see 2 points here:* It's something you can review in ½ a hour, if not even the "famous" 10 minutes. You can even use a regexp to help you...
It's a new feature and IMO the community should have a chance to review and decide if a feature should go into the codebase.
A quick commit on the same day simply removes this chance and builds the impression that the committer does not care about what others think. IMO that's not good for community work.
But I'm getting tired of trying to get this spirit transported somehow. Especially when it seems that nobody else really cares about this approach. So we can end this exchange, like you hoped.
I'll have some questions towards OFBIZ-11317 also but I need time to dig deeper.Sure, shoot :)
There's currently only few questions left for me: we have one configuration which uses org.apache.ofbiz.webapp.ftl.OfbizUrlTransform for ofbizUrl and this would not support the controlPath configuration if I don't miss something. Wouldn't it be better to change this to UrlRegexpTransform and deprecate OfbizUrlTransform?
UrlRegexpTransform is located inside the product component but the macro is used in several other components as well. I think it belongs to the framework/webapp instead of applications/product. What do you think?
Thanks, Michael Brohl ecomify GmbH - www.ecomify.de
smime.p7s
Description: S/MIME Cryptographic Signature
