[
https://issues.apache.org/jira/browse/OFBIZ-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650862#action_12650862
]
David E. Jones commented on OFBIZ-2037:
---------------------------------------
I hate to say it, because I can see that a lot of work has gone into this, but
my vote on this one is a big -1.
The reason: there are big data model design changes here, and they seem to be
more complex and difficult to maintain, but also less flexible. There are also
a lot of entities changed without discussion of alternatives, and before any
coding or additional work is done that should be the priority.
In other words, please don't give up, but let's do back up and discuss how we
want to model the data for billing rates.
One trend that I don't like in this patch is that instead of being able to
configure more general and more specific billing rates it's mostly in one big
billing rate with a large number of factors involved. In other words, I can't
setup data to represent that if not overridden by something more specific then
the rate for a certain rate type is always X.
So, starting the discussion about what to model, here are some thoughts about
things to include:
1. rate and currency together (correct the lack of in the current model)
2. general (by rate type, ie billing level) rates for the company, then for a
particular client, then for a particular project
3. override for individuals, perhaps just on the project level (assuming it's a
rare case)
Those are some basic ideas, any others anyone can come up with, especially
based on common needs they have?
The next steps I'm thinking of would be to model from scratch based on these
data elements and the relationships between them, and then see how that model
compares to the current OFBiz model and decide which entities to change,
deprecate, and new ones to create.
> Re-organize RateType, rateAmount and rateCurrency organization in ofbiz.
> --------------------------------------------------------------------------
>
> Key: OFBIZ-2037
> URL: https://issues.apache.org/jira/browse/OFBIZ-2037
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting, humanres, specialpurpose/projectmgr,
> workeffort
> Affects Versions: SVN trunk
> Environment: any
> Reporter: Hans Bakker
> Assignee: Hans Bakker
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: rateChange.diff
>
>
> the rateAmount in ofbiz is defined by the rate type and then by the following
> criteria when defined:
> from most specific to most general:
> 1. for a partyId (partyRate)
> 2. for a workEffort/timeentry (workEffortAssignmentRate)
> 3. for a employee position (EmplPositionTypeRate)
> 4. for a the default rateTypeId (RateType)
> The currency is defined in level 1,4 but not in the others. It should also be
> possible to specify the currency at any level.
> What is proposed:
> ===========
> 1. remove currencyUomId and (normal)rate(amount) in the partyRate and
> rateType (level 1,4) entities
> 2. remove rate(amount) from the workEffortAssignmentRate and employee
> position (level 2,3) entities
> 3. create a new entity: RateAmount with the following fields:
> primary key:
> rateTypeId
> rateCurrencyUomId
> workEffortId
> partyId
> emplPositionTypeId
> periodTypeId (from the PeriodType entity: per
> hour/day/week/month/quarter)
> fromDate
> non-key fields:
> thruDate
> rateAmount
> 4. create a service "getRateAmount" which will retrieve the applicable rate
> amount for the data provided searching from most specific to most general
> 5. depreciate the getPartyRate service.
> 6. create the createRateAmount and deleteRateAmount(expire) service to update
> the new entity
> 7. update existing services and forms.
> QUESTION:
> should the accounting organization partyId be in the key of the new
> RateAmount entity?
> Regards,
> Hans
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
