[ 
https://issues.apache.org/jira/browse/OFBIZ-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650873#action_12650873
 ] 

David E. Jones commented on OFBIZ-2037:
---------------------------------------

I gave specifics, and it seems the only way to resolve them is to start with 
the data model and build up, and really design it and then build or change what 
you've built as needed. Again, if you disagree and refuse, then what can I do 
but wait until the next time someone wants to revamp these (and hopefully it 
doesn't end up having to be in the very near future).

> Re-organize RateType, rateAmount and rateCurrency organization in ofbiz.  
> --------------------------------------------------------------------------
>
>                 Key: OFBIZ-2037
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2037
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, humanres, specialpurpose/projectmgr, 
> workeffort
>    Affects Versions: SVN trunk
>         Environment: any
>            Reporter: Hans Bakker
>            Assignee: Hans Bakker
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: rateChange.diff
>
>
> the rateAmount in ofbiz is defined by the rate type and then by the following 
> criteria when defined:
> from most specific to most general:
> 1. for a partyId (partyRate)
> 2. for a workEffort/timeentry (workEffortAssignmentRate)
> 3. for a employee position (EmplPositionTypeRate)
> 4. for a the default rateTypeId (RateType)
> The currency is defined in level 1,4 but not in the others. It should also be 
> possible to specify the currency at any level.
> What is proposed:
> ===========
> 1. remove currencyUomId and (normal)rate(amount) in the partyRate and 
> rateType (level 1,4) entities
> 2. remove rate(amount) from the workEffortAssignmentRate and employee 
> position (level 2,3) entities
> 3. create a new entity: RateAmount with the following fields:
>       primary key:
>               rateTypeId
>               rateCurrencyUomId
>               workEffortId
>               partyId
>               emplPositionTypeId
>               periodTypeId (from the PeriodType entity: per 
> hour/day/week/month/quarter)
>               fromDate
>       non-key fields:
>               thruDate
>               rateAmount
> 4. create a service "getRateAmount" which will retrieve the applicable rate 
> amount for the data provided searching from most specific to most general
> 5. depreciate the getPartyRate service.
> 6. create the createRateAmount and deleteRateAmount(expire) service to update 
> the new entity
> 7. update existing services and forms.
> QUESTION:
> should the accounting organization partyId be in the key of the new 
> RateAmount entity?
> Regards,
> Hans

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to