Re: svn commit: r820578 - in /ofbiz/trunk: applications/marketing/config/ applications/marketing/webapp/sfa/party/ applications/marketing/widget/sfa/ applications/marketing/widget/sfa/forms/ applications/order/script/org/ofbiz/order/opportunity/ applicatio...

[Vikas Mayur]

Hans,

Please see my comments inline.
Btw, I think there are certain simple things that are easier to catch  
on first review before committing code, like this one :)

Thanks,
Vikas

On Oct 1, 2009, at 2:30 PM, hans...@apache.org wrote:

--- ofbiz/trunk/applications/party/config/PartyUiLabels.xml (original)
+++ ofbiz/trunk/applications/party/config/PartyUiLabels.xml Thu Oct   
1 09:00:19 2009
@@ -10086,4 +10086,22 @@
        <value xml:lang="th">ไม่ได้ใส่รหภ
±à¸ªà¹„ปรษณีย์/รหัสพื้นที่</value>
        <value xml:lang="zh">æ‰¾ä¸åˆ°é‚®æ”¿ç¼–ç </value>
    </property>
+    <property key="RelatedCompany">
+        <value xml:lang="en">Related Company</value>
+    </property>

Key should prefix the name of the component so that key should  
PartyRelatedCompany


+    <property key="PartyIdFrom">
+        <value xml:lang="en">Party Id From</value>
+    </property>

This exists in other component as well.


+    <property key="PartyStatusId">
+        <value xml:lang="en">Status ID</value>
+    </property>

+    <property key="PartyDateCreated">
+        <value xml:lang="en">Created</value>
+    </property>

+    <property key="PartyDateSend">
+        <value xml:lang="en">Send</value>
+    </property>

Duplicates. All three labels already exists in CommonUiLabels


+    <property key="PartyCreateSaleOpportunityFromCommEvent">
+        <value xml:lang="en">Create Opportunity</value>
+    </property>

Might have been a more consistent and simple name for the key?


</resource>