Hi Vikas, thank you for for your comments, they are corrected in revision 820895
Regards, Hans On Thu, 2009-10-01 at 15:49 +0530, Vikas Mayur wrote: > Hans, > > Please see my comments inline. > > Btw, I think there are certain simple things that are easier to catch > on first review before committing code, like this one :) > > Thanks, > Vikas > > On Oct 1, 2009, at 2:30 PM, [email protected] wrote: > > > --- ofbiz/trunk/applications/party/config/PartyUiLabels.xml (original) > > +++ ofbiz/trunk/applications/party/config/PartyUiLabels.xml Thu Oct > > 1 09:00:19 2009 > > @@ -10086,4 +10086,22 @@ > > <value xml:lang="th">à¹à¸¡à¹à¹à¸à¹à¹à¸ªà¹à¸£à¸«à¸ > > ±à¸ªà¹à¸à¸£à¸©à¸à¸µà¸¢à¹/รหัสà¸à¸·à¹à¸à¸à¸µà¹</value> > > <value xml:lang="zh">æ¾ä¸å°é®æ¿ç¼ç </value> > > </property> > > + <property key="RelatedCompany"> > > + <value xml:lang="en">Related Company</value> > > + </property> > > Key should prefix the name of the component so that key should > PartyRelatedCompany > > > > > + <property key="PartyIdFrom"> > > + <value xml:lang="en">Party Id From</value> > > + </property> > > This exists in other component as well. > > > > > + <property key="PartyStatusId"> > > + <value xml:lang="en">Status ID</value> > > + </property> > > > > + <property key="PartyDateCreated"> > > + <value xml:lang="en">Created</value> > > + </property> > > > > + <property key="PartyDateSend"> > > + <value xml:lang="en">Send</value> > > + </property> > > Duplicates. All three labels already exists in CommonUiLabels > > > > > + <property key="PartyCreateSaleOpportunityFromCommEvent"> > > + <value xml:lang="en">Create Opportunity</value> > > + </property> > > Might have been a more consistent and simple name for the key? > > > > > </resource> > -- Antwebsystems.com: Quality OFBiz services for competitive rates
