Hi Devs
This is indicator of how poor community is getting about commitment to
deliver good quality project. We just don't need new features. We need
good quality software that we can use to build our company.
This is not first time we have seen this bad quality of work. Its
become practice. Looking at bad economy people are working for low
rates and then delivering bad project to customer and to the community
as well.
This is frustrating.
Regards
Anil Patel
On Oct 1, 2009, at 6:19 AM, Vikas Mayur wrote:
Hans,
Please see my comments inline.
Btw, I think there are certain simple things that are easier to
catch on first review before committing code, like this one :)
Thanks,
Vikas
On Oct 1, 2009, at 2:30 PM, [email protected] wrote:
--- ofbiz/trunk/applications/party/config/PartyUiLabels.xml
(original)
+++ ofbiz/trunk/applications/party/config/PartyUiLabels.xml Thu
Oct 1 09:00:19 2009
@@ -10086,4 +10086,22 @@
<value xml:lang="th">à’≥มà’√à’≥à¸
‰à’≈à’∞สà’√รหà¸
±à¸ªà’≥à¸˝à¸£à¸©à¸„à¸µà¸¢à’‘/à¸
£à¸«à¸±à¸ªà¸ıืà’≈à¸˙ธีà’√</
value>
<value xml:lang="zh">æ≈≤丟å√°é≠®æ‰
¿çπˆç ™</value>
</property>
+ <property key="RelatedCompany">
+ <value xml:lang="en">Related Company</value>
+ </property>
Key should prefix the name of the component so that key should
PartyRelatedCompany
+ <property key="PartyIdFrom">
+ <value xml:lang="en">Party Id From</value>
+ </property>
This exists in other component as well.
+ <property key="PartyStatusId">
+ <value xml:lang="en">Status ID</value>
+ </property>
+ <property key="PartyDateCreated">
+ <value xml:lang="en">Created</value>
+ </property>
+ <property key="PartyDateSend">
+ <value xml:lang="en">Send</value>
+ </property>
Duplicates. All three labels already exists in CommonUiLabels
+ <property key="PartyCreateSaleOpportunityFromCommEvent">
+ <value xml:lang="en">Create Opportunity</value>
+ </property>
Might have been a more consistent and simple name for the key?
</resource>