Re: svn commit: r835637 - in /ofbiz/trunk/framework/entity: build.xml src/org/ofbiz/entity/sql/ src/org/ofbiz/entity/sql/Parser.jjt src/org/ofbiz/entity/sql/SQLSelect.java

[Adrian Crum]

Adam Heath wrote:

Adrian Crum wrote:

I'm wondering that too.

Btw, in the "classic" visitor pattern, the code should be:

/** Accept the visitor. **/
    public Object jjtAccept(ParserVisitor visitor) {
        return visitor.visit(this);
    }

The SQLSelect class shouldn't be concerned with (or know about) Object
data.

I can't change that.  jjtree auto-generates missing node classes, and
this is the pattern is uses.  I only have to override the nodes that
need special functionality.

Thanks. I figured that out after I pressed Send.