Adam,

I just committed a minor change to the Converters class that will help simplify your code. You can create a static instance of StringToInteger and eliminate the factory method call.

The factory method is intended to be used when you don't know the source and target classes at compile time.

-Adrian

Adrian Crum wrote:
Adam Heath wrote:
Adrian Crum wrote:
I'm wondering that too.

Btw, in the "classic" visitor pattern, the code should be:

/** Accept the visitor. **/
    public Object jjtAccept(ParserVisitor visitor) {
        return visitor.visit(this);
    }

The SQLSelect class shouldn't be concerned with (or know about) Object
data.

I can't change that.  jjtree auto-generates missing node classes, and
this is the pattern is uses.  I only have to override the nodes that
need special functionality.

Thanks. I figured that out after I pressed Send.


Reply via email to