From: "Adam Heath" <[email protected]>
On 05/21/2012 09:55 AM, Jacques Le Roux wrote:
Could not the asm library (not sure what it is exactly) be loaded on
the fly with Cobertura?
The less optional libs we have inside, the more we resolve with Ivy,
the less issues we get (from all POV)
cobertura parses .class files with asm, and adds markup to record
method entry/exit, so that it can do coverage. asm in the best(imho)
library for that.
And what do you mean, 'on the fly'? No matter *how* the classes are
loaded, they have to exist somewhere in the local checkout. Right
now, they don't *at all*.
I mean like run-tests-with-cobertura does:
<<Download Cobertura and perform code coverage (same as run-tests). You will need a valid Internet connection to download
cobertura>>
These libs are not needed by the ERP in itself. I mean all of these added libs.
I don't know much Ivy and if it's powerful enough to revolve a dependencies (like Maven does). But a least it's able to pick the
last version of a needed lib, just need to fill the requested in ivy.xml.
BTW maybe we just need to remove this line?
<exclude module="asm" conf="cobertura"/>
We want to let people easily get what they need in their working copy, but not clutter the repo with optional libs to maintain
(guess who maintain them?)
Jacques
From: <[email protected]>
Author: doogie
Date: Mon May 21 13:43:39 2012
New Revision: 1341021
URL: http://svn.apache.org/viewvc?rev=1341021&view=rev
Log:
FIX: Cobertura's version was changed in 1230444, but it wasn't changed
in common.xml; this fixes it, so that you can now sorta-run
'tests-cobertura' in framework/base. However, that requires the asm
library, which was recently removed, so it still doesn't completely
function.
This is part of the fix for OFBIZ-4783.
Modified:
ofbiz/trunk/common.xml
Modified: ofbiz/trunk/common.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/common.xml?rev=1341021&r1=1341020&r2=1341021&view=diff
==============================================================================
--- ofbiz/trunk/common.xml (original)
+++ ofbiz/trunk/common.xml Mon May 21 13:43:39 2012
@@ -134,7 +134,7 @@ under the License.
<taskdef resource="tasks.properties">
<classpath>
<fileset dir="${ofbiz.home.dir}/framework/base/lib">
- <include name="cobertura-1.9.3.jar" />
+ <include name="cobertura-1.9.4.1.jar" />
<include name="log4j-1.2.16.jar" />
</fileset>
<fileset
dir="${ofbiz.home.dir}/framework/base/lib/scripting">
