On 05/21/2012 10:47 AM, Jacques Le Roux wrote:
> From: "Adam Heath" <[email protected]>
>> On 05/21/2012 09:55 AM, Jacques Le Roux wrote:
>>> Could not the asm library (not sure what it is exactly) be loaded on
>>> the fly with Cobertura?
>>>
>>> The less optional libs we have inside, the more we resolve with Ivy,
>>> the less issues we get (from all POV)
>>
>> cobertura parses .class files with asm, and adds markup to record
>> method entry/exit, so that it can do coverage.  asm in the best(imho)
>> library for that.
>>
>> And what do you mean, 'on the fly'?  No matter *how* the classes are
>> loaded, they have to exist somewhere in the local checkout.  Right
>> now, they don't *at all*.
> 
> I mean like  run-tests-with-cobertura  does:
> <<Download Cobertura and perform code coverage (same as run-tests).
> You will need a valid Internet connection to download cobertura>>

Right now, this is what I need to see working:

==
cd framework/base
../../ant clean
../../ant tests-cobertura
==

That is a bit quicker to debug then the full-blown test suite.

> These libs are not  needed by the ERP in itself. I mean all of these
> added libs.

Well, you *can* run the high-level test suite with cobertura, and that
will also need asm.

> I don't know much Ivy and if it's powerful enough to revolve a
> dependencies  (like Maven does). But a least it's able to pick the
> last version of a needed lib, just need to fill the requested in ivy.xml.
> 
> BTW maybe we just need to remove this line?
> <exclude module="asm" conf="cobertura"/>

Checking.  Close.  Needed to remove asm, asm-tree, and oro from the
exclusion.  But at least now it works.

I wouldn't be against using some other lib, that was apache friendly
for code coverage.  But there isn't one.  And, of the actual libs that
*do* coverage, cobertura is really rather nice.

> We want to let people easily get what they need in their working copy,
> but not clutter the repo with optional libs to maintain (guess who
> maintain them?)

I'm not suggesting to check in asm or cobertura, I'm happy having them
downloaded.  Since they aren't checked in, the mainteance becomes a
little bit simpler.

As I've mentioned elsewhere, I've been busy the last year, so haven't
kept up with things as I should.  I'm trying to play catchup now.

Reply via email to