Ruth,
I understand your viewpoint. Personally, I prefer to present my ideas to
the dev list to see if it is something the dev community wants included
in the project. Users might like a new feature, but that doesn't mean
the dev community wants it in the project. If there was no interest from
the dev community, then I would offer it as an add-on product and
announce it on the user list.
I am also a user, and the design was based on the requirement to monitor
and control server performance. I suppose I could go to the user list
for more ideas, but the code I'm planning to commit is pretty basic, and
users will be free to enhance it in whatever way they please.
-Adrian
On 7/15/2012 12:13 PM, Ruth Hoffman wrote:
Hi Adrian:
Shouldn't this be discussed on the "user" list? IMHO Words like
"applications" and "stats about services and entities"...those are all
indicative of user requirements, not developer requirements.
Users should be driving requirements gathering and analysis for OFBiz
and not developers.
Just my 2 cents.
Regards,
Ruth
On 7/15/12 4:41 AM, Adrian Crum wrote:
On 7/14/2012 3:40 PM, Jacopo Cappellato wrote:
On Jul 14, 2012, at 4:18 PM, Adrian Crum wrote:
At first glance, this might seem like a duplication of
ServerHitBin.java, but it isn't. The metrics Java code will be in
the base component, and it is designed to be used to measure any
part of the project, not just web app requests.
-Adrian
I know that there are features in the ServerHitBin class to gather
stats about services and entities, but I don't remember how they are
implemented and if they are fully used.
Jacopo
The ServerHitBin entity and service methods are not used currently.
Metrics could be kept for entities, but I don't think that they would
be meaningful - so I didn't add them. If someone comes up with a need
for entity metrics, then the capability can be added easily.
In a nutshell, the ServerHitBin code is quite heavy - it uses the
entity engine to store the metrics. The design I used is from SEDA -
it is meant to be used in a "feedback loop" that is used to control
web application response times, so it is small and fast. Also,
ServerHitBin stats are kept for every request, but the metrics code
is more strategic - you maintain metrics only in the areas you are
concerned with.
-Adrian
