[
https://issues.apache.org/jira/browse/OFBIZ-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446725#comment-13446725
]
Jacques Le Roux commented on OFBIZ-5020:
----------------------------------------
OK, the databases which use upper case column names is a strong argument
against 3rd solution I did not think about. I'd then personnally be more
inclined with the std solution (2nd). Then it's clear and without possible
confusion, notably about seed and demo data.
I guess one of the reasons which pushed Nicolas to this change is that
AccountingTypeData.xml are seed data with for instance
<CustomMethodType customMethodTypeId="FIN_CAPTURE" parentTypeId=""
hasTable="N" description="FIN account capture methods"/>
<CustomMethodType customMethodTypeId="FIN_REFUND" parentTypeId=""
hasTable="N" description="FIN account refund methods"/>
<CustomMethodType customMethodTypeId="FIN_RELEASE" parentTypeId=""
hasTable="N" description="FIN account release methods"/>
but nothing for
+ <CustomMethodType customMethodTypeId="FIN_PURCHASE" parentTypeId=""
hasTable="N" description="FIN account purchase methods"/>
See his last patches for more about that (followed Scott's remark). Now it's up
to you Nicolas, the 1st solution is clearly easier, you could just add a
comment about the new solution in the field description without changing the
field name... Then no need to update the wiki page, etc.
> change serviceName by customMethod on Content
> ---------------------------------------------
>
> Key: OFBIZ-5020
> URL: https://issues.apache.org/jira/browse/OFBIZ-5020
> Project: OFBiz
> Issue Type: Improvement
> Components: content
> Affects Versions: SVN trunk
> Reporter: Nicolas Malin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch
>
>
> At this time, when you use a content as template, the content.serviceName
> value use to call the context populate service before rendering.
> I propose to replace serviceName field by customMethodId and use customMethod
> pattern for more flexibility.
> serviceName field will be move to oldServiceName field for backward
> compatibility
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
