[ 
https://issues.apache.org/jira/browse/OFBIZ-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin updated OFBIZ-5020:
---------------------------------

    Attachment: OFBiz-5020-migrate.patch
                OFBiz-5020.patch

Hi, 

I update the patch with the first solution without upgrade service.

I create a new patch that contains only upgrade service OFBiz-5020-migrate.patch

just to don't waste time for all, on wiki page I found this :
{quote}
Deprecated Entities
...
When changing the name of a field, or deprecating and replacing a field that 
does not require deprecation of the entire entity, then follow the same pattern 
leaving the old field there: a "old" prefix added to the field name, change the 
original first letter to upper case, and specify the column-name for the field 
so it is the same as the original field name. For example if you are changing 
the "uomId" field to a new name then change the field name to "oldUomId" and 
specify a column-name of "UOM_ID". Just as when replacing and entity, make sure 
to write a service to move the data from the old field to the new one.
{quote}

It's a best pratice or not ? Because I followed this to make my improvement, 
and I'm a little disturbed by the response around my initial proposition (It's 
just to understand and improve my issue quality)  

Thks
                
> change serviceName by customMethod on Content
> ---------------------------------------------
>
>                 Key: OFBIZ-5020
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5020
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBiz-5020-migrate.patch, OFBiz-5020.patch, 
> OFBIZ-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch
>
>
> At this time, when you use a content as template, the content.serviceName 
> value use to call the context populate service before rendering.
> I propose to replace serviceName field by customMethodId and use customMethod 
> pattern for more flexibility.
> serviceName field will be move to oldServiceName field for backward 
> compatibility

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to