[
https://issues.apache.org/jira/browse/OFBIZ-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446814#comment-13446814
]
Jacques Le Roux edited comment on OFBIZ-5020 at 9/2/12 8:38 AM:
----------------------------------------------------------------
== WRAP LINE ==
Hi Nicolas,
Yes, then it's come back to my initial request in my Jira comment of the commit
which I wrote from the top of my head w/out checking anything (like you to be
able to edit this page)
{quote}
Since you replaced the serviceName by oldServiceName please fill an entry in
https://cwiki.apache.org/confluence/display/OFBTECH/Revisions+Requiring+Data+Migration+%28upgrade+ofbiz%29
{quote}
The only differences with the patch you proved intially are
* you did not write the col-name in upper case (not sure why it should be upper
case rather than lower though) but rather suggested this (quoting you in dev
ML) <<On my initial proposition, I keep serviceName on oldServiceName for
transparent evolution without script migration. An other solution will be
convert all serviceName present on Content to customMethod data by conversion
script>>
* you take into account the oldServiceName field in your code for backward
compatibility, which was for me rather a good thing for people which might have
been missed the migration script in wiki. But then it was confusing ;)
was (Author: jacques.le.roux):
Hi Nicolas,
Yes, then it's come back to my initial request in my Jira comment of the commit
which I wrote from the top of my head w/out checking anything (like you to be
able to edit this page)
{quote}
Since you replaced the serviceName by oldServiceName please fill an entry in
https://cwiki.apache.org/confluence/display/OFBTECH/Revisions+Requiring+Data+Migration+%28upgrade+ofbiz%29
{quote}
The only differences with the patch you proved intially are
* you did not write the col-name in upper case (not sure why it should be upper
case rather than lower though) but rather suggested this (quoting you in dev
ML) <<On my initial proposition, I keep serviceName on oldServiceName for
transparent evolution without script migration. An other solution will
be convert all serviceName present on Content to customMethod data by
conversion script>>
* you take into account the oldServiceName field in your code for backward
compatibility, which was for me rather a good thing for people which might have
been missed the migration script in wiki. But then it was confusing ;)
It's too late for me tonight, but yes we have to check that...
> change serviceName by customMethod on Content
> ---------------------------------------------
>
> Key: OFBIZ-5020
> URL: https://issues.apache.org/jira/browse/OFBIZ-5020
> Project: OFBiz
> Issue Type: Improvement
> Components: content
> Affects Versions: SVN trunk
> Reporter: Nicolas Malin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBiz-5020-migrate.patch, OFBiz-5020.patch,
> OFBIZ-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch
>
>
> At this time, when you use a content as template, the content.serviceName
> value use to call the context populate service before rendering.
> I propose to replace serviceName field by customMethodId and use customMethod
> pattern for more flexibility.
> serviceName field will be move to oldServiceName field for backward
> compatibility
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
