There have been many Start.java refactorings in the past that did not
require review. Why is this one different?
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 4/18/2015 6:24 PM, Jacques Le Roux wrote:
Le 18/04/2015 19:12, Adrian Crum a écrit :
I spent the day looking through the OFBiz startup code to see if there
is any way we can shorten the startup time.
Something I noticed that seems odd...
Start.java searches the OFBiz folders for all instances of
ofbiz-component.xml files, parses them, and builds a class path based
on their contents. Then Start.java loads the components using
ComponentContainer.java, and that class also parses
ofbiz-component.xml files. So the ofbiz-component.xml files are parsed
twice.
I would like to redesign the component loading a bit to eliminate the
double parsing.
What do you think?
This would need a review to confirm, but if the double parsing is
useless then indeed a refactoring seems the way.
This is the kind of change we could wait to be reviewed before
committing, but not necessarily since we can always revert
Jacques
