Le 18/04/2015 22:20, Adrian Crum a écrit :
RTC will bring the project to a screeching halt - because no one reviews anything. I'm still waiting for feedback on the entity cache fix I
committed a while ago.
"no one reviews anything. "
That's *almost* right Adrian, we review some I believe ;) and I think Pierre
has a point here, as your previous email about r1633182 shows.
I think it's something we should really care more about. For important commits in the core, we can't rely only on one person, even among our most
experienced core developers.
Obviously the "deeper" a commit is, the more chances are it has a negative impact, contrary to a change, for instance, at the UI level. We have proofs
everyday, having something working is not enough.
We (all committers) should even, as a priority, focus on such changes. Of course it's not the easiest job so we often prefer to close our eyes and
rely on others, I know, I do that.
Now, I don't believe asking for review on such important patch attached to a Jira would throw OFBiz in "a screeching halt", at least when it's not
about a bug fix. Refactoring and improving is nice, but we all know it also introduce some risks. I have the feeling we crossed some regressions we
could have avoided with a more community minded spirit. I know you often ask for reviews when doing such changes and we sometimes lack to provide
them. But that should not prevent us to ask for RTC when we have the feeling it should be done. I did in the recent past by attaching patches to Jira,
not sure I got more attention, but at least I tried.
We knowcoercion is impossible due to the nature of the project. So maybe putting more pressure (reiterated, if no feedbacks) on RTC requests would
help, before committing something w/o enough eyes balls reviews. And a patch in a Jira is the best way to keep things focused.
BTW I will begin by doing the reviews I promised I would do...
Thanks!
Jacques
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 4/18/2015 8:08 PM, Pierre Smits wrote:
We should learn from the past, not repeat it. RTC would have brought this
aspect of the improvement in r1633182 earlier to our attention than CTR.
Best regards,
Pierre Smits
*ORRTIZ.COM <http://www.orrtiz.com>*
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com
On Sat, Apr 18, 2015 at 7:39 PM, Adrian Crum <
[email protected]> wrote:
There have been many Start.java refactorings in the past that did not
require review. Why is this one different?
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 4/18/2015 6:24 PM, Jacques Le Roux wrote:
Le 18/04/2015 19:12, Adrian Crum a écrit :
I spent the day looking through the OFBiz startup code to see if there
is any way we can shorten the startup time.
Something I noticed that seems odd...
Start.java searches the OFBiz folders for all instances of
ofbiz-component.xml files, parses them, and builds a class path based
on their contents. Then Start.java loads the components using
ComponentContainer.java, and that class also parses
ofbiz-component.xml files. So the ofbiz-component.xml files are parsed
twice.
I would like to redesign the component loading a bit to eliminate the
double parsing.
What do you think?
This would need a review to confirm, but if the double parsing is
useless then indeed a refactoring seems the way.
This is the kind of change we could wait to be reviewed before
committing, but not necessarily since we can always revert
Jacques
