Hi Mridul and everyone, Thank you all for your inputs. May I also ask you Mridul while you are at it to delete the rest of the files so the whole task resides with you to avoid crossing any wires.
Also, I suggest to name that component into something like archives or reference and put a README file that says this component does not compile and it holds this stuff. This way it is easy to isolate that component from the build system. Thank you all again for your contributions. Taher Alkhateeb -----Original Message----- From: Mridul Pathak [mailto:[email protected]] Sent: 15 June 2016 11:09 To: [email protected] Cc: Mridul Pathak Subject: Re: Proposal to delete stale java files I would like to volunteer for this change (moving payment, shipping and tax integrations to specialpurpose). -- Mridul Pathak On Wednesday 15 June 2016, Jacopo Cappellato < [email protected]> wrote: > Based on the new comments it seems like that we could isolate the > shipment, payment and tax integration classes (and artifacts that use > them) into their own specialpurpose components (waiting for a better > pluggable components architecture); they will not be compiled by > default but each component will have its own readme file containing > instructions about how to deploy and use them. > As regards the JasperReports*, JRE* and openoffice ones I think they > can go to Attic since they are old and unmaintained. > > Does it make sense? Any volunteers to create the new specialpurpose > components and upgrade/isolate the shipment/payment/tax integration > classes into them? > > Jacopo > > On Wed, Jun 15, 2016 at 9:32 AM, Hans Bakker > <[email protected] <javascript:;>> > wrote: > > > +1 > > > > > > On 15/06/16 13:30, Ashish Vijaywargiya wrote: > > > >> I would prefer to keep Tax and Third Party Payment gateway > >> files(The > files > >> that does exists inside cybersource, ideal, orbital, paypal, > >> securepay, verisign etc). If you see some problems in those code > >> base, like code > base > >> is not updated based on latest changes then we can update those files. > >> Those files might have been used by so many users that we can't > >> know because we are doing this conversation on Dev mailing list. We > >> should > not > >> remove those files. > >> > >> -- > >> Kind Regards > >> Ashish Vijaywargiya > >> HotWax Systems - est. 1997 > >> > >> On Tue, Jun 14, 2016 at 7:40 PM, Taher Alkhateeb < > >> [email protected] <javascript:;> > >> > >>> wrote: > >>> > >> > >> Hi Everyone, > >>> > >>> I cannot actually believe it but while I was working on a project > >>> (I > will > >>> announce later) I discovered in the process that the below files > >>> cannot compile!!! They existed for years in the code base without > >>> even being able to compile. They reference non existent libraries > >>> or they have faulty code (e.g. not importing used code) > >>> > >>> I propose to delete them immediately from trunk > >>> > >>> > >>> > >>> > applications/accounting/src/org/ofbiz/accounting/thirdparty/cybersourc > e/IcsPaymentServices.java > >>> > >>> > >>> > applications/accounting/src/org/ofbiz/accounting/thirdparty/ideal/Idea > lEvents.java > >>> > >>> > >>> > applications/accounting/src/org/ofbiz/accounting/thirdparty/ideal/Idea > lPaymentServiceTest.java > >>> > >>> > >>> > applications/accounting/src/org/ofbiz/accounting/thirdparty/orbital/Or > bitalPaymentServices.java > >>> > >>> > >>> > applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/Pay > PalServices.java > >>> > >>> > >>> > applications/accounting/src/org/ofbiz/accounting/thirdparty/securepay/ > SecurePayPaymentServices.java > >>> > >>> > >>> > applications/accounting/src/org/ofbiz/accounting/thirdparty/securepay/ > SecurePayServiceTest.java > >>> > >>> > >>> > applications/accounting/src/org/ofbiz/accounting/thirdparty/verisign/P > ayflowPro.java > >>> > >>> > >>> > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteAr > rayInputStream.java > >>> > >>> > >>> > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteAr > rayOutputStream.java > >>> > >>> > >>> > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeServic > es.java > >>> > >>> > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeWorker > .java > >>> applications/content/src/org/ofbiz/content/report > >>> > >>> > >>> > applications/content/src/org/ofbiz/content/report/JREntityListIterator > DataSource.java > >>> > >>> > >>> > applications/content/src/org/ofbiz/content/report/JRMapCollectionDataS > ource.java > >>> applications/order/src/org/ofbiz/order/thirdparty/taxware > >>> > >>> > >>> > applications/order/src/org/ofbiz/order/thirdparty/taxware/TaxwareExcep > tion.java > >>> > >>> > >>> > applications/order/src/org/ofbiz/order/thirdparty/taxware/TaxwareServi > ces.java > >>> > applications/order/src/org/ofbiz/order/thirdparty/taxware/TaxwareUTL.j > ava > >>> applications/product/src/ShipmentScaleApplet.java > >>> > >>> > >>> > applications/securityext/src/org/ofbiz/securityext/thirdparty/truition > /TruitionCoReg.java > >>> > >>> > >>> > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsJXlsViewHandle > r.java > >>> > >>> > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPdfViewHandler > .java > >>> > >>> > >>> > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPoiXlsViewHand > ler.java > >>> > >>> > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsXmlViewHandler > .java > >>> > >>> Regards, > >>> > >>> Taher Alkhateeb > >>> > >>> > >> > > -- > > > > Regards, > > > > Hans Bakker > > CEO, http://antwebsystems.com > > > -- Mridul Pathak Senior Manager HotWax Systems http://www.hotwaxsystems.com direct: +91-942592692
