I would prefer to keep Tax and Third Party Payment gateway files(The files that does exists inside cybersource, ideal, orbital, paypal, securepay, verisign etc). If you see some problems in those code base, like code base is not updated based on latest changes then we can update those files. Those files might have been used by so many users that we can't know because we are doing this conversation on Dev mailing list. We should not remove those files.
-- Kind Regards Ashish Vijaywargiya HotWax Systems - est. 1997 On Tue, Jun 14, 2016 at 7:40 PM, Taher Alkhateeb <[email protected] > wrote: > Hi Everyone, > > I cannot actually believe it but while I was working on a project (I will > announce later) I discovered in the process that the below files cannot > compile!!! They existed for years in the code base without even being able > to compile. They reference non existent libraries or they have faulty code > (e.g. not importing used code) > > I propose to delete them immediately from trunk > > > applications/accounting/src/org/ofbiz/accounting/thirdparty/cybersource/IcsPaymentServices.java > > applications/accounting/src/org/ofbiz/accounting/thirdparty/ideal/IdealEvents.java > > applications/accounting/src/org/ofbiz/accounting/thirdparty/ideal/IdealPaymentServiceTest.java > > applications/accounting/src/org/ofbiz/accounting/thirdparty/orbital/OrbitalPaymentServices.java > > applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalServices.java > > applications/accounting/src/org/ofbiz/accounting/thirdparty/securepay/SecurePayPaymentServices.java > > applications/accounting/src/org/ofbiz/accounting/thirdparty/securepay/SecurePayServiceTest.java > > applications/accounting/src/org/ofbiz/accounting/thirdparty/verisign/PayflowPro.java > > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayInputStream.java > > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayOutputStream.java > > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeServices.java > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeWorker.java > applications/content/src/org/ofbiz/content/report > > applications/content/src/org/ofbiz/content/report/JREntityListIteratorDataSource.java > > applications/content/src/org/ofbiz/content/report/JRMapCollectionDataSource.java > applications/order/src/org/ofbiz/order/thirdparty/taxware > > applications/order/src/org/ofbiz/order/thirdparty/taxware/TaxwareException.java > > applications/order/src/org/ofbiz/order/thirdparty/taxware/TaxwareServices.java > applications/order/src/org/ofbiz/order/thirdparty/taxware/TaxwareUTL.java > applications/product/src/ShipmentScaleApplet.java > > applications/securityext/src/org/ofbiz/securityext/thirdparty/truition/TruitionCoReg.java > > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsJXlsViewHandler.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPdfViewHandler.java > > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPoiXlsViewHandler.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsXmlViewHandler.java > > Regards, > > Taher Alkhateeb >
