Nicely said, thanks Sharan :)
Jacques
Le 15/06/2016 à 09:14, Sharan Foga a écrit :
Hi Everyone
If we don't compromise on this then we are going to make the re-factoring effort that Taher is driving even harder. If we want to clean the code
base (and I really think we do) then we need to take the some hard decisions. I'm sure that this won't be the last discussion over code removal so
let's start getting used to it.
The framework*must *have none of these dependencies (reverse or otherwise) so if we want to improve the quality of our code then the truth is - it
really needs to go. In fact, for me these type of integrations fall into the addons category so that is what I think we should be looking at. If we
need it then someone please re-write it as an OFBiz addon.
We are going to totally transform our current trunk and when we are finished it will be totally different to what it is today. In the meantime –
please remember that we currently have 2 un-released OFBiz versions 14.12 and 15.12 where the code we are talking about will remain as it is. This
will give us time to complete our transformation work and also time for our user base time to adjust to what will come.
Thanks
Sharan
On 15/06/16 09:01, Mridul Pathak wrote:
Yes, accounting/thirdparty has all the third party payment integrations supported by OFBiz. And, order/thridparty seems to have third party tax
integration. We should not be deleting these files. I think we should refactor these third party integration files, and move these integrations to
specialpurpose rather than keeping them with main applications. A bit off topic but shipping integrations reside with main application code as
well, so that again is a candidate to be moved to specialpurpose. Any of such third party application integrations should be maintained separately.
--
Thanks & Regards,
Mridul Pathak
Senior Manager
HotWax Systems
http://www.hotwaxsystems.com
On Jun 15, 2016, at 12:00 PM, Ashish Vijaywargiya
<[email protected]> wrote:
I would prefer to keep Tax and Third Party Payment gateway files(The files
that does exists inside cybersource, ideal, orbital, paypal, securepay,
verisign etc). If you see some problems in those code base, like code base
is not updated based on latest changes then we can update those files.
Those files might have been used by so many users that we can't know
because we are doing this conversation on Dev mailing list. We should not
remove those files.
--
Kind Regards
Ashish Vijaywargiya
HotWax Systems - est. 1997
On Tue, Jun 14, 2016 at 7:40 PM, Taher Alkhateeb <[email protected]
wrote:
Hi Everyone,
I cannot actually believe it but while I was working on a project (I will
announce later) I discovered in the process that the below files cannot
compile!!! They existed for years in the code base without even being able
to compile. They reference non existent libraries or they have faulty code
(e.g. not importing used code)
I propose to delete them immediately from trunk
applications/accounting/src/org/ofbiz/accounting/thirdparty/cybersource/IcsPaymentServices.java
applications/accounting/src/org/ofbiz/accounting/thirdparty/ideal/IdealEvents.java
applications/accounting/src/org/ofbiz/accounting/thirdparty/ideal/IdealPaymentServiceTest.java
applications/accounting/src/org/ofbiz/accounting/thirdparty/orbital/OrbitalPaymentServices.java
applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalServices.java
applications/accounting/src/org/ofbiz/accounting/thirdparty/securepay/SecurePayPaymentServices.java
applications/accounting/src/org/ofbiz/accounting/thirdparty/securepay/SecurePayServiceTest.java
applications/accounting/src/org/ofbiz/accounting/thirdparty/verisign/PayflowPro.java
applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayInputStream.java
applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayOutputStream.java
applications/content/src/org/ofbiz/content/openoffice/OpenOfficeServices.java
applications/content/src/org/ofbiz/content/openoffice/OpenOfficeWorker.java
applications/content/src/org/ofbiz/content/report
applications/content/src/org/ofbiz/content/report/JREntityListIteratorDataSource.java
applications/content/src/org/ofbiz/content/report/JRMapCollectionDataSource.java
applications/order/src/org/ofbiz/order/thirdparty/taxware
applications/order/src/org/ofbiz/order/thirdparty/taxware/TaxwareException.java
applications/order/src/org/ofbiz/order/thirdparty/taxware/TaxwareServices.java
applications/order/src/org/ofbiz/order/thirdparty/taxware/TaxwareUTL.java
applications/product/src/ShipmentScaleApplet.java
applications/securityext/src/org/ofbiz/securityext/thirdparty/truition/TruitionCoReg.java
framework/webapp/src/org/ofbiz/webapp/view/JasperReportsJXlsViewHandler.java
framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPdfViewHandler.java
framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPoiXlsViewHandler.java
framework/webapp/src/org/ofbiz/webapp/view/JasperReportsXmlViewHandler.java
Regards,
Taher Alkhateeb
