Why wouldn't it use the start up loader logic? What would it do instead? On 22 July 2016 at 01:18, Taher Alkhateeb <[email protected]> wrote:
> You got it right Scott. they load the both.properties and pos.properties > which in return contain the initializing classes to fire up POS. so this is > no different from say starting a mobile application which has nothing to do > with OFBiz from the start component. it should really start on its own > without going through the start up loader logic > > On Thursday, 21 July 2016, Scott Gray <[email protected]> > wrote: > > > My memory is hazy, but don't those commands simply tell OFBiz which > > [command].properties file to use for initialization? > > > > Regards > > Scott > > > > On 21 July 2016 at 21:38, Taher Alkhateeb <[email protected] > > <javascript:;>> > > wrote: > > > > > Hello Everyone, > > > > > > This is a proposal to _remove_ the following commands from the OFBiz > > server > > > (invoked with ./gradlew "ofbiz --commandHere" > > > > > > 1- --both > > > 2- --pos > > > 3- --testlist > > > > > > Reasons: > > > - The POS component is a specialpurpose component and should not have > > code > > > existing in the start component. Instead logic for starting the POS > > > component should reside inside the POS component and away from > framework > > > - After lots of investigation I realized the testlist OFBiz command is > a > > > weird command that used to create an ant file that just iterates over > the > > > existing integration test suites and run them one by one, which is > slower > > > vs just running them all. It is deprecated and to my knowledge no one > is > > > using it. I think it used to serve some deprecated cobertura tasks. > > > > > > This would imply deleting the following files: > > > - > > > > > > > > > framework/start/src/main/java/org/apache/ofbiz/base/start/testlist.properties > > > - > > > > > > > > > framework/testtools/src/main/java/org/apache/ofbiz/testtools/TestListContainer.java > > > - > > > > > > framework/base/src/main/java/org/apache/ofbiz/base/splash/SplashLoader.java > > > > > > and modifying the following files: > > > - framework/start/src/main/java/org/apache/ofbiz/base/start/Config.java > > > - > > > > > > > > > framework/start/src/main/java/org/apache/ofbiz/base/start/StartupCommandUtil.java > > > - (move it to POS) > > > > > > framework/base/src/main/java/org/apache/ofbiz/base/splash/SplashScreen.java > > > > > > Agreed? > > > > > > Regards, > > > > > >
