Yep, will do, waiting for other opinions before...
Jacques
Le 12/08/2016 à 13:28, Taher Alkhateeb a écrit :
Also another note Jacques, if things are a WIP, I suggest not to commit
before testing functionality. I know we are in trunk, but at least
committing working code is better than fixing it after a commit.
On Fri, Aug 12, 2016 at 2:25 PM, Taher Alkhateeb <[email protected]
wrote:
I see no problem in this renaming. It makes things shorter and nicer.
However, please make sure to update all references in README.md in the
entire file.
If you make this renaming, may I suggest then to remove the start and
debug tasks?
On Fri, Aug 12, 2016 at 2:20 PM, Jacques Le Roux <
[email protected]> wrote:
Hi Taher,
I agree, and thanks for the details! It was a WIP, I knew it was not the
right way but did not have time to do it right.
You know what? I'm lazy, especially when typing on my keyboard ! :)
So I love the Gradle possibility of using shortcuts. For instance with my
local g.bat cover for gradlew.bat I created, I only type "g ta" to list the
tasks, etc.
The problem with prefixing patterns with ofbiz, as in ofbizDebug,
ofbizSecure, ofbizBackground, ofbizBackgroundSecure is you can't benefit
from shortcuts.
I sincerely see no points using the ofbiz prefix for patterns, we know
it's OFBiz ;)
So why not having rather the patterns named debug, secure, background,
backgroundSecure ;) (I got not ideas to shorten backgroundSecure, not a big
deal I guess)
I just tried renaming the patterns everywhere in OFBiz and it works like
a charm (at least for debug instead of ofbizDebug that I just used), so we
get:
Rules
-----
Pattern: clean<TaskName>: Cleans the output files of a task.
Pattern: build<ConfigurationName>: Assembles the artifacts of a
configuration.
Pattern: upload<ConfigurationName>: Assembles and uploads the artifacts
belonging to a configuration.
Pattern: ofbiz <Commands>: Execute OFBiz startup commands
Pattern: debug <Commands>: Execute OFBiz startup commands in remote debug
mode
Pattern: secure <Commands>: Execute OFBiz startup commands pre-loading
the notsoserial Java agent
Pattern: background <Commands>: Execute OFBiz startup commands in
background and output to console.log
Pattern: backgroundSecure <Commands>: Execute OFBiz startup commands in
background (secure mode) and output to console.log
The ofbiz pattern by itself makes sense since it's used with the start
options, that's why I created the lazy start and stop cover tasks
Opinions, before I commit my tiny changes (including "debug task" revert)?
Jacques
Le 12/08/2016 à 12:21, Taher Alkhateeb a écrit :
Hi Jacques, all,
I noticed that you added a task called debug in the master build script.
It
is not working because the syntax is incorrect (should be "ofbizDebug",
not
"ofbiz ofbizDebug".
However, I recommend removing this task and let developers use the
ofbizDebug directly. Why? because ofbizDebug activates the debugger on
everything (--test --load-data --shutdown --start --help) So it helps
developers in debugging any scenario. If you keep the debug task then
developers might not be aware that they have these different combinations
of debugging options available.
Taher Alkhateeb
