Jacques,the parenthesis comes from our blog post format where we put the JIRA issue reference just behind the title (you know it because we are working together on this every month).
Of course, we can parse without the parenthesis and set them when we generate the development details. But again, we already agreed upon this format and I don't see a big effort for a committer to put parenthesis around the Jira issue.
The above example is an exception when it comes to effort. We normally have one JIRA reference in the commit messages.
When I count the time we already spent discussing these nitpicking details, you could have written a whole bunch of correct commit messages in this time. You are making it very hard to establish such a simple guideline.
Thanks for your support, Michael Am 12.09.16 um 11:37 schrieb [email protected]:
Author: jleroux Date: Mon Sep 12 09:37:11 2016 New Revision: 1760325 URL: http://svn.apache.org/viewvc?rev=1760325&view=rev Log: Fixes: a bug introduced with one of (OFBIZ-8118)(OFBIZ-8122)(OFBIZ-8123)(OFBIZ-8124)(OFBIZ-8125)(OFBIZ-8126)(OFBIZ-8127)(OFBIZ-8128)(OFBIZ-8129) I put the parenthesis here just because I copied from r1760059. In other cases I'll not except if it's *really* needed. I don't see why a simple space between Jira issues numbers would not be better, or not parenthesis at all for a sole issue. Is it for parsing and then why? Modified: ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml Modified: ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml?rev=1760325&r1=1760324&r2=1760325&view=diff ============================================================================== --- ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml (original) +++ ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml Mon Sep 12 09:37:11 2016 @@ -156,8 +156,8 @@ <set field="partyId" from-field="parameters.partyId"/> </actions> <widgets> - <screenlet title="${uiLabelMap.PartyPartyIdentifications}" navigation-menu-name="newPartyIdentification" id="PartyIdentificationPanel"> - <include-menu name="newPartyIdentification" location="component://party/widget/partymgr/PartyMenus.xml"/> + <screenlet title="${uiLabelMap.PartyPartyIdentifications}" navigation-menu-name="NewPartyIdentification" id="PartyIdentificationPanel"> + <include-menu name="NewPartyIdentification" location="component://party/widget/partymgr/PartyMenus.xml"/> <include-form name="listPartyIdentification" location="component://party/widget/partymgr/PartyForms.xml"/> </screenlet> </widgets>
smime.p7s
Description: S/MIME Cryptographic Signature
