Hi Jacques, all,
From my experience, having a commit concerning lots of different JIRA
is rare.
In this case, don't you thinkthat the list of JIRAcould not be in the
detail sectionand written in a more simple way OFBIZ-8118, OFBIZ-8122,
OFBIZ-8123, etc.
Indeed, in the commit message template, the Jira in parenthesis
represents the bug/improvement/new feature ticket, in that case no Jira
have been registered describing the specific bug you fixed (which is not
a problem), Having a Jira is not mandatory...
Then this kind of commit message could be like (very simple one :) ):
Fixes: Fix wrong menu name of NewPartyIdentification in XXXX screens
This bug has been introduced with one of OFBIZ-8118, OFBIZ-8122,
OFBIZ-8123, OFBIZ-8124, OFBIZ-8125, OFBIZ-8126, OFBIZ-8127, OFBIZ-8128,
OFBIZ-8129
WDYT ?
Gil
Le 12/09/2016 à 15:51, Jacques Le Roux a écrit :
Michael,
Le 12/09/2016 à 14:30, Michael Brohl a écrit :
Jacques,
the parenthesis comes from our blog post format where we put the JIRA
issue reference just behind the title (you know it because we are
working together on this every month).
Sorry, I did not notice this aspect. Do we really need parenthesis
there, what does it add. A simple list separated by spaces would not
be enough? It seems it would even easier to read to me.
Of course, we can parse without the parenthesis and set them when we
generate the development details. But again, we already agreed upon
this format and I don't see a big effort for a committer to put
parenthesis around the Jira issue.
Sorry, I see a big difference with commits like the one below!
The above example is an exception when it comes to effort. We
normally have one JIRA reference in the commit messages.
When I count the time we already spent discussing these nitpicking
details, you could have written a whole bunch of correct commit
messages in this time. You are making it very hard to establish such
a simple guideline.
Again, I really don't see the need for the parenthesis. And I'd be
happy to change that myself once in wiki and elsewhere it's needed
rather than have to type it every time I commit (yes I commit a lot :p)
Jacques
Thanks for your support,
Michael
Am 12.09.16 um 11:37 schrieb jler...@apache.org:
Author: jleroux
Date: Mon Sep 12 09:37:11 2016
New Revision: 1760325
URL: http://svn.apache.org/viewvc?rev=1760325&view=rev
Log:
Fixes: a bug introduced with one of
(OFBIZ-8118)(OFBIZ-8122)(OFBIZ-8123)(OFBIZ-8124)(OFBIZ-8125)(OFBIZ-8126)(OFBIZ-8127)(OFBIZ-8128)(OFBIZ-8129)
I put the parenthesis here just because I copied from r1760059. In
other cases I'll not except if it's *really* needed. I don't see why
a simple space between Jira issues numbers would not be better, or
not parenthesis at all for a sole issue. Is it for parsing and then
why?
Modified:
ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml
Modified:
ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml?rev=1760325&r1=1760324&r2=1760325&view=diff
==============================================================================
---
ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml
(original)
+++
ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml
Mon Sep 12 09:37:11 2016
@@ -156,8 +156,8 @@
<set field="partyId"
from-field="parameters.partyId"/>
</actions>
<widgets>
- <screenlet
title="${uiLabelMap.PartyPartyIdentifications}"
navigation-menu-name="newPartyIdentification"
id="PartyIdentificationPanel">
- <include-menu name="newPartyIdentification"
location="component://party/widget/partymgr/PartyMenus.xml"/>
+ <screenlet
title="${uiLabelMap.PartyPartyIdentifications}"
navigation-menu-name="NewPartyIdentification"
id="PartyIdentificationPanel">
+ <include-menu name="NewPartyIdentification"
location="component://party/widget/partymgr/PartyMenus.xml"/>
<include-form name="listPartyIdentification"
location="component://party/widget/partymgr/PartyForms.xml"/>
</screenlet>
</widgets>
