Michael, inline...
Le 12/09/2016 à 16:36, Michael Brohl a écrit :
Am 12.09.16 um 15:51 schrieb Jacques Le Roux:
Please do not start to question the blog style/format now, we use it for months, you reviewed it for month and did not raise such a question anytime
in the past. Why now?
Because, to paraphrase Lisp nickname, I don't want a /Lots of Irritating Superfluous Parentheses/ everywhere
https://en.wikipedia.org/wiki/Lisp_(programming_language)#cite_note-LEVIN2-38
Kidding with the Lisp reference ;) But I guess you get my point, why should I
add parentheses when I don't need them?
1. It would be easier to read in the wiki (sorry for not spotting that earlier)
2. It would be easier to commit
3. It's still easy to change now, will not in the future
And I clearly stated that the below commit is an exception, we normally only have one issue reference per commit. And following Gil's smart
suggestion, the other Jira references could go in the details section without the parenthesis. I would be fine with that.
I don't want an exceptional rule for exceptional cases. I just don't want a
/Lots of Irritating Superfluous Parentheses/ everywhere
Again, I really don't see the need for the parenthesis. And I'd be happy to change that myself once in wiki and elsewhere it's needed rather than
have to type it every time I commit (yes I commit a lot :p)
Please, Jacques, that's ridiculous.
You already have checked in your personal Tortoise template in SVN, you didn't have to type anything except the Jira number for this part of the
commit message.
If I use (OFBIZ-xxxx) I have to get to the position where to put the number so
1. Get to the line (any mean)
2. Ctrl+ -> key twice (or End key then <- key)
3. Type the number
If I use OFBIZ- I have to get to the position where to put the number so
1. Get to the line (any mean)
2. End key
3. Type the number
It's the Ctrl+ -> key twice that I wanted to avoid. But I found after that I can also use End key + <- key End and I can agree that it's not that bad
and I could use it
I though still don't understand why you want /Parentheses/ around Jira issue numbers in the blog and hence in commits. What does it add in 1st place?
I'd really want to have an answer to this question :-o
Jacques
Until now, you seem to be the only one objecting against the proposed format, other committers have given +1 and showed support for it. They even
use it right now.
But I will not stick to the proposal if there are other objections.
So fellow committers, let's hear what you think.
Thanks,
Michael
