Yup +1 for option 3, fix as you edit On Sep 13, 2016 1:16 PM, "Jacques Le Roux" <jacques.le.r...@les7arts.com> wrote:
> Le 13/09/2016 à 11:56, Michael Brohl a écrit : > >> Same here. I'm not even sure if we really have clean groovy in the >> project, I assume it is mixed up with Java code in some areas. >> >> But I agree to have a consistent style and we should use the Groovy >> language as it shoul be used (even if I would have get used to it and like >> a a defined code line ending better). >> >> I see the following directions: >> >> 1. actively migrate to pure groovy and remove the semicolons (where >> applicable, it seems there are some cases where you need them, see >> https://dzone.com/articles/groovy-sometimes-you-still) >> >> 2. activeley put semicolons everywhere for consistency >> >> 3. do 1., but only when a groovy file is edited anyway. This would slowly >> migrate groovy files. >> >> I'd be in favor for 3., as long as there are other more important things >> to do or there is a volunteer to do it. >> > > This is what I somehow suggested, thanks for clarifying Michael! Better to > have consistent lines (with respect to semicolons) by file indeed. > > Jacques > > >> Am 13.09.16 um 08:49 schrieb Taher Alkhateeb: >> >>> Okay I missed the historical context. >>> >>> Like Jacopo I also do not have a strong opinion, if it is easier and >>> faster >>> to keep them, then keep them. The important thing is to take a direction >>> and stay with it. >>> >>> >>> >> >> >
