Le 16/09/2016 à 11:18, Taher Alkhateeb a écrit :
Hi Jacques,
Yeah I looked at your explanation, still doable, in fact, it seems to be a
great thing to do in Groovy. A couple of hours in authoring a script could
iterate through all the variations and clean them up, and that could be
part of our tools. We would really benefit from writing scripts to cleanup
our XML, I'm going to add this to my future todo list.
Anyway, for the record I'm not suggesting we _must_ do it in one shot, just
suggesting it would be better / easier to do it that way and then automate
it with a script that we can use in the future as part of QA.
Yes I agree that a such tool which would give the same result or better than
what we already have would be great!
Jacques
On Fri, Sep 16, 2016 at 8:28 AM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:
Did you have a look at OFBIZ-8154 and the related code :-o ?
Jacques
Le 16/09/2016 à 07:16, Taher Alkhateeb a écrit :
Simple, loop over the labels, and for each label if it exists anywhere
don't delete it, else, delete it.
On Sep 16, 2016 8:15 AM, "Jacques Le Roux" <jacques.le.r...@les7arts.com>
wrote:
You need to know which patterns to use, the difficulty is not technical
but functional
Jacques
Le 16/09/2016 à 07:04, Taher Alkhateeb a écrit :
Why would you think it is difficult? Seems like good old pattern matching
to me.
On Sep 15, 2016 10:28 PM, "Jacques Le Roux" <
jacques.le.r...@les7arts.com
wrote:
Le 15/09/2016 à 21:19, Taher Alkhateeb a écrit :
I think unused labels should be removed. I also think it is not too
hard
to
find and delete all such labels in one shot. We can develop a script
to
do
that and use it on a recurring basis actually.
Actually this already exists, and it's maybe not as simple as you
would
think, see https://issues.apache.org/jira/browse/OFBIZ-8154
Jacques
Unfortunately we have unused XML not only in labels but many other XML
resources making them dead code. This is an area ripe for refactoring.
On Sep 15, 2016 10:13 PM, "Pierre Smits" <pierre.sm...@gmail.com>
wrote:
Maybe we should discuss each individual label? Or do you believe you
can
use your own judgement to do the right thing?
Pierre Smits
ORRTIZ.COM <http://www.orrtiz.com>
OFBiz based solutions & services
OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/
On Thu, Sep 15, 2016 at 9:09 PM, Pierre Smits <
pierre.sm...@gmail.com>
wrote:
That goes to show that not much attention was paid when they got in.
Pierre Smits
ORRTIZ.COM <http://www.orrtiz.com>
OFBiz based solutions & services
OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/
On Thu, Sep 15, 2016 at 8:50 PM, jler...@apache.org <
jler...@apache.org
wrote:
Hi,
While working on OFBIZ-8154 I noticed that the labels beginning by
"HumanResServices." are never used.
So, it's a pity, but I think they should be removed. Actually my
question
is more if we agree about removing all unused labels, not only those
ones.
Thanks
