Github user ebortnik commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/13#discussion_r130563983 --- Diff: hbase-client/src/main/java/org/apache/omid/transaction/TTable.java --- @@ -158,12 +162,40 @@ public Result get(Transaction tx, final Get get) throws IOException { Result result = table.get(tsget); List<Cell> filteredKeyValues = Collections.emptyList(); if (!result.isEmpty()) { - filteredKeyValues = filterCellsForSnapshot(result.listCells(), transaction, tsget.getMaxVersions()); + filteredKeyValues = filterCellsForSnapshot(result.listCells(), transaction, tsget.getMaxVersions(), new HashMap<String, List<Cell>>()); } return Result.create(filteredKeyValues); } + private void familyQualifierBasedDeletion(HBaseTransaction tx, Put deleteP, Get deleteG) throws IOException { + Result result = this.get(tx, deleteG); + if (!result.isEmpty()) { --- End diff -- Better to return here if the result is empty
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---